-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨Implement infinite article loading on amp-next-page
v2
#26296
Merged
wassgha
merged 20 commits into
ampproject:master
from
wassgha:amp-next-page-v2-infinite-loading
Jan 23, 2020
Merged
✨Implement infinite article loading on amp-next-page
v2
#26296
wassgha
merged 20 commits into
ampproject:master
from
wassgha:amp-next-page-v2-infinite-loading
Jan 23, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey @ampproject/wg-caching, these files were changed:
|
wassgha
force-pushed
the
amp-next-page-v2-infinite-loading
branch
from
January 15, 2020 19:03
765f672
to
63b4407
Compare
16 tasks
1 task
wassgha
requested review from
honeybadgerdontcare
and removed request for
twifkak
January 21, 2020 17:20
wassgha
requested review from
alanorozco
and removed request for
honeybadgerdontcare
January 21, 2020 21:43
caroqliu
requested changes
Jan 22, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM, just a few questions. Great work on this!
wassgha
force-pushed
the
amp-next-page-v2-infinite-loading
branch
from
January 22, 2020 22:19
a64afba
to
202ed6d
Compare
caroqliu
approved these changes
Jan 23, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job!!
This was referenced Jun 24, 2020
This was referenced Mar 16, 2021
This was referenced May 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
amp-next-page
configuration on child pages (while avoiding loops)