Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨Implement infinite article loading on amp-next-page v2 #26296

Merged
merged 20 commits into from
Jan 23, 2020
Merged

✨Implement infinite article loading on amp-next-page v2 #26296

merged 20 commits into from
Jan 23, 2020

Conversation

wassgha
Copy link
Contributor

@wassgha wassgha commented Jan 10, 2020 •
edited
Loading

Changes

  • Implements infinite loading of articles from parsed amp-next-page configuration on child pages (while avoiding loops)
  • Implements unloading and reloading of pages to free up memory once the user scrolls too far away from a page
  • Fixes some types + minor cleanup
  • Implement unit tests for the changes

@wassgha
Added visual diff tests and better manual tests
2c60f47
@wassgha
Prototyping sticky element handling in amp-next-page
fd8de0d
@wassgha
Merge branch 'master' into amp-next-page-v2-hide-elements
5733c3e
@wassgha
Merge branch 'master' into amp-next-page-v2-visual-diff
35c9f61
@wassgha
Deprecate amp-next-page-keep in favor of amp-next-page-hidden
bac73c6
@wassgha
Visibility bug fix
8295a33
@wassgha
Remove animation added for testing
bf9e8a6
@wassgha
Exported host-page-specific parameters into HostPage
2085a36
@wassgha
Merge branch 'master' into amp-next-page-v2-hide-elements
aca949b
@wassgha
Preventing next-page form building again
72ce30f
@wassgha
Merge branch 'master' into amp-next-page-v2-visual-diff
3c38550
@wassgha
Remove visual diff tests
d12c8c6
@wassgha
Merge branch 'amp-next-page-v2-visual-diff' into amp-next-page-v2-inf…
0a35078 
…inite-loading
@wassgha
Implement infinite loading for amp-next-page v2
81a3e93
@amp-owners-bot
Copy link

Hey @ampproject/wg-caching, these files were changed:

  • validator/validator-main.protoascii

@wassgha wassgha mentioned this pull request Jan 13, 2020
Merged
@twifkak twifkak self-requested a review January 13, 2020 21:01
@wassgha wassgha force-pushed the amp-next-page-v2-infinite-loading branch from 765f672 to 63b4407 Compare January 15, 2020 19:03
@wassgha wassgha requested a review from caroqliu January 17, 2020 16:57
@wassgha wassgha marked this pull request as ready for review January 17, 2020 16:58
@wassgha wassgha mentioned this pull request Jan 20, 2020
Closed
16 tasks
@wassgha wassgha mentioned this pull request Jan 20, 2020
Merged
1 task
@wassgha wassgha requested review from honeybadgerdontcare and removed request for twifkak January 21, 2020 17:20
@wassgha wassgha requested review from alanorozco and removed request for honeybadgerdontcare January 21, 2020 21:43
caroqliu
caroqliu requested changes Jan 22, 2020
View reviewed changes
Copy link
Contributor

@caroqliu caroqliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, just a few questions. Great work on this!

extensions/amp-next-page/1.0/page.js Show resolved Hide resolved
extensions/amp-next-page/1.0/service.js Outdated Show resolved Hide resolved
extensions/amp-next-page/1.0/service.js Outdated Show resolved Hide resolved
extensions/amp-next-page/1.0/service.js Outdated Show resolved Hide resolved
extensions/amp-next-page/1.0/service.js Outdated Show resolved Hide resolved
@wassgha wassgha force-pushed the amp-next-page-v2-infinite-loading branch from a64afba to 202ed6d Compare January 22, 2020 22:19
@wassgha wassgha requested a review from caroqliu January 23, 2020 00:27
caroqliu
caroqliu approved these changes Jan 23, 2020
View reviewed changes
Copy link
Contributor

@caroqliu caroqliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!!

@wassgha wassgha merged commit 6a7c345 into ampproject:master Jan 23, 2020
@wassgha wassgha deleted the amp-next-page-v2-infinite-loading branch January 23, 2020 17:05
This was referenced Jun 24, 2020
Closed
Closed
Closed
@ampprojectbot ampprojectbot mentioned this pull request Jul 3, 2020
Closed
This was referenced Mar 16, 2021
Open
Closed
@ampprojectbot ampprojectbot mentioned this pull request Apr 2, 2021
Closed
This was referenced May 22, 2021
Closed
Closed
@ampprojectbot ampprojectbot mentioned this pull request Aug 28, 2021
Closed
@ampprojectbot ampprojectbot mentioned this pull request Jan 18, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@honeybadgerdontcare honeybadgerdontcare honeybadgerdontcare left review comments

@caroqliu caroqliu caroqliu approved these changes

@alanorozco alanorozco Awaiting requested review from alanorozco

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wassgha @honeybadgerdontcare @caroqliu @googlebot