Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export CJS auto generate extern #235

Merged
merged 1 commit into from
Nov 22, 2019
Merged

Export CJS auto generate extern #235

merged 1 commit into from
Nov 22, 2019

Conversation

kristoferbaxter
Copy link
Contributor

When the output is a CJS file, and the author is attempting to use Advanced Optimizations... we need to provide Closure Compiler an extern for the exports global used by Babel and TypeScript to indicate an input was originally a ESM module.

Copy link

@nainar nainar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kristoferbaxter kristoferbaxter merged commit 2d4f237 into master Nov 22, 2019
@kristoferbaxter kristoferbaxter deleted the export-cjs branch November 22, 2019 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants