Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Exports, Add UTF-8 Tests #277

Merged
merged 10 commits into from
Jan 9, 2020
Merged

Conversation

kristoferbaxter
Copy link
Contributor

This is a long awaited refactoring of export support to make it easier to add additional support in the future.

Additionally, this PR adds a test for UTF8 imports.

@codecov-io
Copy link

codecov-io commented Jan 9, 2020

Codecov Report

Merging #277 into master will increase coverage by 0.07%.
The diff coverage is 96.98%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #277      +/-   ##
==========================================
+ Coverage   96.44%   96.52%   +0.07%     
==========================================
  Files          18       20       +2     
  Lines        1520     1667     +147     
  Branches      141      154      +13     
==========================================
+ Hits         1466     1609     +143     
- Misses         51       55       +4     
  Partials        3        3
Impacted Files Coverage Δ
src/index.ts 89.58% <100%> (+0.81%) ⬆️
src/parsing/preserve-named-constant-export.ts 100% <100%> (ø)
src/transformers/strict.ts 96.77% <100%> (ø) ⬆️
src/parsing/preserve-default-export.ts 100% <100%> (ø)
src/temp-file.ts 96.42% <100%> (ø) ⬆️
src/parsing/literal-name.ts 100% <100%> (+4.54%) ⬆️
src/compiler.ts 98.07% <100%> (+0.03%) ⬆️
src/options.ts 95.48% <100%> (+0.06%) ⬆️
src/parsing/import-specifiers.ts 100% <100%> (+4.16%) ⬆️
src/transformers/imports.ts 97.18% <100%> (ø) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35853c3...34d9389. Read the comment docs.

@kristoferbaxter kristoferbaxter merged commit 1ff3e2f into master Jan 9, 2020
@kristoferbaxter kristoferbaxter deleted the exports-refactoring branch January 9, 2020 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants