Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Canvas API #380
Implement Canvas API #380
Changes from 4 commits
ca5b033
9daba15
dfebb96
d810e14
3f20f3e
237e34c
797b3cb
3e625be
fca3af6
b3d0a32
95d3a14
ad8e8bb
ade3271
60e1f81
74bb308
5fd3614
3f84ccd
fe54ac6
36f9696
8f5eb73
584cba3
506f654
8a73ccc
ef45d03
a13a52f
58443e2
afb3306
d0f4415
4013812
cbcdd76
9a1cd14
85784df
a74fbad
bc3572f
dd4e5a6
29f4204
e06cfb6
5e046e8
ae376f6
57d29cb
6b5b80f
33b7724
efedcab
81f6a25
b1b40f9
dd9ee4e
19e6d19
bad9acc
95f37ee
1e75f01
3da8531
3c14f7d
69abf90
ad0e4b9
46bc90f
78bdadf
c9f5f7c
526a4ac
93adcbf
d31a005
c254ca3
49c4f77
47445fd
56706c9
e81eaf9
f5884de
d8acae7
49d38f1
303da7f
59e5eb6
b8ad611
c11599e
b6a2254
37ebe23
207155e
8c0dfe3
c5d9893
6c294e7
f6fb0f3
7008704
a174656
d6d1bb3
ee8d4ef
d51fb79
e29eaa0
a424b2a
e419317
c32e90e
a6e11f7
4cde664
b2a5a54
86f8ed5
b82070f
5edc97a
7730c80
b5c0dc6
1e7b7f9
ce20391
4a3c909
67ce3b2
c39a38e
09e0dbf
3a4edf4
d1e58bd
1afb6ed
17cabfd
f0d1b3b
a0e3276
a105d69
120eec2
37204db
5bb059c
283dbec
cae19fd
79ebff9
65b2c32
3d8ce3d
16a1a64
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a comment explaining why we need to declare this here. I assume it's because OffscreenCanvas types is not available in TS yet?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct.
transferControlToOffscreen
is not detected as a method because of this.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be an optional parameter instead of forcing all messages without transferables to pass an empty array?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes :)