Skip to content

Commit

Permalink
Bump uglify version and tested NodeJS 9-series
Browse files Browse the repository at this point in the history
Uglify 2.4 has a vulnerability that doesn't affect users of this
library, but does result in build warnings:
https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2015-8858

Early minor versions of NodeJS 9.x inherited a bug from V8 that led to
repeated test failures: nodejs/node#16781.
  • Loading branch information
squaremo committed Jul 9, 2018
1 parent 962fb9e commit 55d08ba
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ node_js:
- "5.5"
- "6.12"
- "8.9"
- "9.1"
- "9.11"
- "node"

services:
Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ RABBITMQ_SRC_VERSION=rabbitmq_v3_2_1
JSON=amqp-rabbitmq-0.9.1.json
RABBITMQ_CODEGEN=https://raw.githubusercontent.com/rabbitmq/rabbitmq-codegen
AMQP_JSON=$(RABBITMQ_CODEGEN)/$(RABBITMQ_SRC_VERSION)/$(JSON)
NODEJS_VERSIONS='0.8' '0.9' '0.10' '0.11' '0.12' '1.6' '2.5' '3.3' '4.2' '5.5' '6.2' '8.9' '9.1'
NODEJS_VERSIONS='0.8' '0.9' '0.10' '0.11' '0.12' '1.6' '2.5' '3.3' '4.2' '5.5' '6.2' '8.9' '9.11'

MOCHA=./node_modules/.bin/mocha
_MOCHA=./node_modules/.bin/_mocha
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
"devDependencies": {
"mocha": "~1",
"claire": "0.4.1",
"uglify-js": "2.4.x",
"uglify-js": "2.6.x",

This comment has been minimized.

Copy link
@kibertoad

kibertoad Sep 10, 2018

Collaborator

Considering that uglify is no longer maintained, any plans to start using terser instead?

This comment has been minimized.

Copy link
@squaremo

squaremo Sep 11, 2018

Author Collaborator

No plans; uglify works (until it doesn't). I will keep terser in mind though for that parenthetical case..

"istanbul": "0.1.x"
},
"scripts": {
Expand Down

0 comments on commit 55d08ba

Please sign in to comment.