Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for AMQP 1.0? #99

Closed
noodlefrenzy opened this issue Sep 29, 2014 · 7 comments
Closed

Support for AMQP 1.0? #99

noodlefrenzy opened this issue Sep 29, 2014 · 7 comments
Labels

Comments

@noodlefrenzy
Copy link

Is there any support for AMQP 1.0 in the works?

I'm a developer at MSFT, not on the Azure team, and we were trying to read from EventHub so need AMQP 1.0. I'd be willing to help develop this support, but I want to make sure I'm not contending with someone else who might already be doing the work. Please let me know if you're actively working on it, and if so, what I can do to help.

Thanks!

@michaelklishin
Copy link

AMQP 1.0 is a completely different protocol. See #94, #63.

@squaremo
Copy link
Collaborator

Hi @noodlefrenzy, I'm not working on or planning to work on adding AMQP 1.0 to this library -- I'd have to start from scratch, since everything from the codec upwards is different to AMQP 0.9.1. It may as well be another library.

You may have more luck making a Node.JS binding to proton http://qpid.apache.org/proton/.

@squaremo
Copy link
Collaborator

You may have more luck making a Node.JS binding to proton http://qpid.apache.org/proton/.

Oh here we go, someone has at least started that: https://github.com/pofallon/node-qpid

squaremo added a commit that referenced this issue Sep 30, 2014
To pre-empt more people asking (#99, etc.)
@noodlefrenzy
Copy link
Author

Yeah, I've been looking at node-qpid and it's based on proton 0.3. I've started the work to port it to the latest proton and get it building on Windows, but also figured I'd investigate more platform-agnostic (i.e. non-native-code) solutions.

I realized 1.0 was an entirely different protocol than 0.9.1, but was just wondering if anyone had started the work of supporting it, since it seems like the standard going forward, for good or ill. Also, sorry I didn't see #63 - I looked, but missed that one :(

Thanks. Feel free to close.

@squaremo
Copy link
Collaborator

Yeah, I've been looking at node-qpid and it's based on proton 0.3. I've started the work to port it to the latest proton and get it building on Windows,

Good stuff. I think that's ultimately going to be the better solution, because AMQP 1.0 is complicated enough that it's worth having as few from-scratch implementations as possible. (The same is arguably true of AMQP 0.9.1 too)

@squaremo
Copy link
Collaborator

By the way @noodlefrenzy, if you get it working to your satisfaction, let me know and I'll link to it from the README here.

@mbroadst
Copy link

mbroadst commented Nov 4, 2015

@squaremo if you're willing I think the project is ready for addition to the README

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants