Fix an issue where links are kept alive #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
even though we are unable to create an Amqp receiver due to operation timeout. The problem is that `rheaReceiver` and `receiver` are created when the Promise instance is created, however, they are not removed when rejecting due to operation timeout. So the created objects are kept by `rhea` as long as the connection is alive. In this case there's no way for outside caller to do the clean up because `receiver` is not returned by the `resolve` callback. This PR adds cleanup for the `actionAfterTimeout` code path.
jeremymeng
commented
Jun 11, 2024
| @@ -396,6 +396,15 @@ export class Session extends Entity { | |||
| const msg: string = `Unable to create the amqp receiver '${receiver.name}' on amqp ` + | |||
| `session '${this.id}' due to operation timeout.`; | |||
| log.error("[%s] %s", this.connection.id, msg); | |||
|
|
|||
There was a problem hiding this comment.
There are reject cases above too but I'd like to limit the scope of this PR to just timeout for now.
HarshaNalluru
approved these changes
Jun 11, 2024
Comment on lines
+400
to
+406
| const createReceiverOptions = options as CreateReceiverOptions; | ||
| if (createReceiverOptions?.session?.createReceiver) { | ||
| // being called on a session passed via the options so don't close the session | ||
| receiver.close({ closeSession: false }).then(() => { receiver.remove(); }) | ||
| } else { | ||
| receiver.close({ closeSession: true }).then(() => { receiver.remove(); }) | ||
| } |
There was a problem hiding this comment.
[NIT]
Should this just be abstracted into a receiverCleanup method so that it can be reused?
There was a problem hiding this comment.
Good point! But could wait until it is going to be re-used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
even though we are unable to create an Amqp receiver due to operation timeout.
The problem is that
rheaReceiverandreceiverare created when the Promiseinstance is created, however, they are not removed when rejecting due to
operation timeout. So the created objects are kept by
rheaas long as theconnection is alive but not usable by any. In this case there's no way for outside
caller to do the clean up because
receiveris not returned by theresolvecallback.This PR adds cleanup for the
actionAfterTimeoutcode path.