updates rhea-promise to 2.0.0 to match rhea dependency being updated to 2.x #87
Conversation
|
Now that we have a major version update allowing us to clean up APIs that would be breaking changes, can we do something about this: #66 (comment) and #66 (comment) |
|
Also, what do we have to gain by having timeout configurable both at the sender and each send level in the AwaitableSender? Can we afford to have it only on the send operation? |
Sure! I think all it will mean is a few more changes to our client packages, but no issues with making this change. |
lib/awaitableSender.ts
Outdated
| * @param {Buffer | string} [tag] The message tag if any. | ||
| * @param {number} [format] The message format. Specify this if a message with custom format needs | ||
| * to be sent. `0` implies the standard AMQP 1.0 defined format. If no value is provided, then the | ||
| * given message is assumed to be of type Message interface and encoded appropriately. | ||
| * @param {AwaitableSendOptions} [options] Options to configure the timeout and cancellation for |
There was a problem hiding this comment.
Can we indicate that AwaitableSendOptions is now much more than timeout and cancellation?
There was a problem hiding this comment.
Updated. Also made the same change for the regular Sender.
Description
rhea has been updated to 2.x, so this PR updates rhea-promise to use rhea 2.x!
There was only one breaking change in rhea: deserializing timestamps as dates instead of numbers.
Since we're doing a major version bump of rhea-promise, I also updated AwaitableSender.send to move the optional positional arguments to the options argument.