Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that frame.payload is truthy #389

Merged
merged 1 commit into from
Nov 29, 2022
Merged

Check that frame.payload is truthy #389

merged 1 commit into from
Nov 29, 2022

Conversation

GeorgeJCleary
Copy link
Contributor

Fix for regression issue for #388

@grs grs merged commit 4f35a89 into amqp:main Nov 29, 2022
@grs
Copy link
Member

grs commented Nov 29, 2022

Thank you @GeorgeJCleary !

@RMueAZD
Copy link

RMueAZD commented Dec 6, 2022

@GeorgeJCleary Thanks!

I'm still confused as to why this empty frame is being sent in the first place.

Plus (this kept me from creating a PR myself):
I couldn't figure out how to create test coverage for this to prevent future regressions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants