Specify the units for Mutual Information scores #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amrcode
force-pushed
the
specify-units-for-mutual-information-metrics
branch
from
3e32ad7 to
f8a079d
Compare
…19641) Co-authored-by: Alek Lefebvre <alek.lefebvre@mail.mcgill.ca> Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
Separate arguments into options and commands, and use setuptools.setup if all the requested commands can / should run without NumPy installed, even if there are options present. This fixes a bug where `setup.py --no-user-site egg_info` wants NumPy to be installed, even though `setup.py egg_info` works fine.
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
…t-learn#19643) Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
…ces (scikit-learn#19571) * Use multi_dot for Hessian and gradient product. np.linalg.multi_dot quickly chooses the best order for the multiplication of three matrices.
…earn#19670) Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com> Co-authored-by: cinbez <cindyb@lightstone.co.za>
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org> Co-authored-by: Christian Lorentzen <lorentzen.ch@gmail.com>
…1_ratio=0) solutions (scikit-learn#19620)
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org> Co-authored-by: Christian Lorentzen <lorentzen.ch@gmail.com>
…earn#19611) Co-authored-by: Roman Yurchak <rth.yurchak@gmail.com>
* Fix typo in elastic net docstring. * Use norms more explicitly.
Co-authored-by: Joris Clement <joris.clement@cyren.com>
…learn#20159) Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org> Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Co-authored-by: Christian Lorentzen <lorentzen.ch@gmail.com> Co-authored-by: Alihan Zihna <alihanz@gmail.com> Co-authored-by: Alihan Zihna <a.zihna@ckhgbdp.onmicrosoft.com> Co-authored-by: Chiara Marmo <cmarmo@users.noreply.github.com> Co-authored-by: Olivier Grisel <olivier.grisel@gmail.com> Co-authored-by: naozin555 <37050583+naozin555@users.noreply.github.com> Co-authored-by: Venkatachalam N <venky.yuvy@gmail.com> Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org> Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com> Co-authored-by: Olivier Grisel <olivier.grisel@gmail.com>
…sformer` (scikit-learn#20191) Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
Co-authored-by: Julien Jerphanion <git@jjerphan.xyz> Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com> Co-authored-by: Chiara Marmo <cmarmo@users.noreply.github.com>
Fix lint issues in doc updates.
…return value doc Co-authored-by: Chiara Marmo <cmarmo@users.noreply.github.com>
Line length adjustment
amrcode
force-pushed
the
specify-units-for-mutual-information-metrics
branch
from
349ceb7 to
26e2064
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds documentation to the return values of the mutual-information-score functions to make it clear that the units are based on the natural logarithm. It also indicates how the parameters are related to the mathematical representations.