Io/pio put att #2
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amstokely
changed the base branch from
atmosphere/mpas-bundle
to
atmosphere/retry_pio_put_att
jim-p-w
reviewed
Jul 26, 2024
src/framework/mpas_io.F
Outdated
| ! type is (real(kind=8)) | ||
| ! pio_ierr = PIO_put_att(handle % pio_file, varid, attName, attValue) | ||
| ! type is (character(len=*)) | ||
| ! pio_ierr = PIO_put_att(handle % pio_file, varid, attName, attValue) |
jim-p-w
reviewed
Jul 26, 2024
| @@ -5846,8 +5751,8 @@ subroutine MPAS_io_put_att_real0d(handle, attName, attValue, fieldname, syncVal, | |||
| #endif | |||
| else | |||
| #ifdef MPAS_PIO_SUPPORT | |||
| pio_ierr = pio_put_att_retry(handle, attName, realValue=attValueLocal) | |||
| !pio_ierr = PIO_put_att(handle % pio_file, varid, attName, attValueLocal) | |||
| call put_att_pio(handle, varid, attName, attValueLocal, ierr=ierr) | |||
There was a problem hiding this comment.
what type does this evaluate to in put_att_generic_pio?
jim-p-w
reviewed
Jul 26, 2024
src/framework/mpas_io.F
Outdated
| pio_ierr = PIO_put_att(handle % pio_file, varid, attName, attValue) | ||
| end select | ||
| ! if (pio_ierr /= PIO_noerr) then | ||
| ! |
There was a problem hiding this comment.
can you log what the error code is here?
jim-p-w
reviewed
Jul 26, 2024
src/framework/mpas_io.F
Outdated
|
|
||
| select type(attValue) | ||
| type is (integer) | ||
| call mpas_log_write('PIO_put_att called for integer attribute '//attName) |
There was a problem hiding this comment.
the point of using STREAM_DEBUG_WRITE is that you can comment out the call to mpas_log_write in the macro instead of deleting code. That way when we run into another mysterious problem you can re-enable the macro.
jim-p-w
reviewed
Jul 26, 2024
| @@ -1571,7 +1571,6 @@ logical function MPAS_stream_mgr_ringing_alarms(manager, streamID, direction, ie | |||
|
|
|||
| threadNum = mpas_threading_get_thread_num() | |||
|
|
|||
| STREAM_DEBUG_WRITE('-- Called MPAS_stream_mgr_ringing_alarms()') | |||
There was a problem hiding this comment.
instead of deleting all of these debug logging you can just comment out the call to mpas_write in the macro.
amstokely
force-pushed
the
io/pio_put_att
branch
from
4d8aab2
to
24c8fce
Compare
…real(kind=4/8) types to real(kind=R4/8KIND) in put_att_pio subroutine.
jim-p-w
reviewed
Jul 29, 2024
| @@ -6089,6 +5994,74 @@ subroutine MPAS_io_put_att_real1d(handle, attName, attValue, fieldname, syncVal, | |||
|
|
|||
| end subroutine MPAS_io_put_att_real1d | |||
|
|
|||
| subroutine put_att_generic_pio(handle, varid, attName, attValue, ierr) | |||
| type (MPAS_IO_Handle_type), intent(inout) :: handle | |||
| character (len=*), intent(in) :: attName | ||
| class(*), intent(in) :: attValue | ||
| integer, optional :: ierr | ||
|
|
There was a problem hiding this comment.
declare integer :: pio_ierr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The title above should be a 1 line short summary of the pull request (i.e. what the project the PR represents is intended to do).
Enter a description of this PR. This should include why this PR was created, and what it does.
Testing and relations to other Pull Requests should be added as subsequent comments.
See the below examples for more information.
MPAS-Dev/MPAS#930
MPAS-Dev/MPAS#931