Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Element should not be required to be an input #323

Open
halcyonandon opened this issue Jan 22, 2014 · 21 comments
Open

Element should not be required to be an input #323

halcyonandon opened this issue Jan 22, 2014 · 21 comments
Labels
Milestone

Comments

@halcyonandon
Copy link

I'm currently using pickatime and needed to add a caret to the element. It also needed to behave as a button, so I did not want to use an input field. I also have experienced issues with the readonly attribute in ie as well as finding the ability to still edit a readonly field in modern browsers.

I got this working fine, but in ie8 and 9, the autofocus breaks the browser with "Object doesn't support this action." error on line 93 "ELEMENT.autofocus..."

@halcyonandon
Copy link
Author

#323 this is the same issue pretty much

@halcyonandon
Copy link
Author

I commented out the line failing and it works for my needs.

@halcyonandon
Copy link
Author

Oh, I just realized, this autofocus line is also probably the cause of the bug where the picker loads when switching tabs after already the user has already used the picker. That bug requires a fix where we blur() onClose. Seems that shouldn't be necessary either.

I'm not sure if autofocus is doing something important I'm unaware of.

@amsul
Copy link
Owner

amsul commented Jan 31, 2014

As of v3.3.1, there’s the option to make the input element editable: http://amsul.ca/pickadate.js/date.htm#editable :)

In regards to the autofocus check, that’s there because if the scripts aren’t loaded before the user focuses on the element, the picker opens when the scripts do become ready.

The issue of the picker re-opening after switching tabs is just the default behavior of browsers. They re-trigger the focus event on the last focused element - in this case that reopens the picker. A couple work arounds were suggested here: #160

But yes, one of the goals in future updates is to allow any element. And so I’ll keep this open.

Cheers.

@softshape
Copy link

Let me second this request. I was going to use pickadate without input, as a dropdown calendar. But so far I can't find any (documented) way to assign it to some button or any other element, which would trigger pickadate dropdown in its position.

@rewmike
Copy link

rewmike commented Feb 22, 2014

@softshape +1 Need a way to update the positioning of the picker

@amsul amsul added the todo label Mar 5, 2014
@amsul amsul added this to the v3.4.2 milestone Apr 12, 2014
@andresmafra
Copy link

The inline pickadate is working?

@dcworldwide
Copy link

+1. I'd like to be able to embed the picker inline within an existing modal.

@Donov4n
Copy link

Donov4n commented Oct 22, 2015

+1

@rachellji
Copy link

+1.

@llinde
Copy link

llinde commented Nov 16, 2015

+1

2 similar comments
@shyaaam
Copy link

shyaaam commented Nov 17, 2015

+1

@Mello21century
Copy link

+1

@jasvrcek
Copy link

jasvrcek commented Jan 5, 2016

+1 for embedded inline date and time pickers.

1 similar comment
@rizopoulos
Copy link

+1 for embedded inline date and time pickers.

@fenegan
Copy link

fenegan commented Feb 26, 2016

+1 for embedded inline date and time pickers.

Last commit on 20 Apr 2015, is this still maintained ? :)

@Davidhidalgo
Copy link

+1!

@rajananimator
Copy link

+1 embedded inline calendar.

@ravijoon
Copy link

ravijoon commented May 6, 2016

+1 for embedded inline date and time pickers.

1 similar comment
@sheillendra
Copy link

+1 for embedded inline date and time pickers.

@ohnu93
Copy link

ohnu93 commented Aug 31, 2016

+1

@amsul amsul modified the milestones: 4.0.0, v3.6.0 Sep 11, 2016
Repository owner locked and limited conversation to collaborators Sep 11, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests