Allow mock Date object in isDate() check #857
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When carrying out automated testing (e.g. with Selenium), and wanting to test different timezones, it's common to mock the global Date object with a library like: https://github.com/plaa/TimeShift-js
Unfortunately, the
isDate
check in pickadate has a very strict check, which rejects anything that isn't a native JSDate
object, rendering this mocking method unusable.I propose making this check more lenient, so as long as the object looks like it matches the
Date
API, it's allowed through.The issue manifests itself in an interesting way -- you end up with a calendar where, in the best case, every single date shows as today, and in the worst case, browser freezes up in an infinite loop.