Skip to content

Commit

Permalink
fix the workflow dispatch to run tests (#144)
Browse files Browse the repository at this point in the history
related to
- https://github.com/amtoine/nu-git-manager/actions/runs/7224981713

## description
as can be seen in the failing workflow dispatch above
> Error when evaluating 'timeout-minutes' for job 'nupm-tests'.
.github/workflows/nupm-tests.yml (Line: 45, Col: 22): Unexpected value
'20'

i'll try and remove the timeout and decided to simplify a bit the
arguments to the dispatch.
  • Loading branch information
amtoine authored Dec 15, 2023
1 parent dcb5140 commit d31ed97
Showing 1 changed file with 4 additions and 15 deletions.
19 changes: 4 additions & 15 deletions .github/workflows/nupm-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,34 +3,24 @@ on:
workflow_dispatch:
inputs:
nu_version:
description: "A valid NPM-style semver specification, such as '0.86.0', etc. and 'nightly', supports '0.60.0' -> latest and latest 'nightly'"
default: "*"
description: "A semver, e.g. `0.12.3`, or `nightly` for the latest revision of Nushell."
required: true
type: string
nupm_revision:
description: "A commit hash, branch name or tag to checkout before installing Nupm."
required: true
default: "*"
type: string
timeout:
description: "The timeout of the ci job. Default is 20min"
default: 20
type: number

workflow_call:
inputs:
nu_version:
description: "A valid NPM-style semver specification, such as '0.86.0', etc. and 'nightly', supports '0.60.0' -> latest and latest 'nightly'"
default: "*"
description: "A semver, e.g. `0.12.3`, or `nightly` for the latest revision of Nushell."
required: true
type: string
nupm_revision:
description: "A commit hash, branch name or tag to checkout before installing Nupm."
required: true
default: "*"
type: string
timeout:
description: "The timeout of the ci job. Default is 20min"
default: 20
type: number

env:
NU_LOG_LEVEL: DEBUG
Expand All @@ -42,7 +32,6 @@ defaults:

jobs:
nupm-tests:
timeout-minutes: ${{ inputs.timeout }}
strategy:
fail-fast: true
matrix:
Expand Down

0 comments on commit d31ed97

Please sign in to comment.