Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test imports exactly #126

Merged
merged 1 commit into from
Dec 4, 2023
Merged

test imports exactly #126

merged 1 commit into from
Dec 4, 2023

Conversation

amtoine
Copy link
Owner

@amtoine amtoine commented Dec 4, 2023

this PR ensures that the import tests are strong.

by strong, i mean that now, they compare the list of commands in scope before and after the use of a given module.
the diff, i.e. the new commands in scope, should be exactly the commands from the module.
the import tests don't rely on a prefix anymore.

@amtoine amtoine added enhancement New feature or request tests Something related to the tests of the library labels Dec 4, 2023
@amtoine amtoine merged commit f91b743 into main Dec 4, 2023
4 checks passed
@amtoine amtoine deleted the stronger-import-tests branch December 4, 2023 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request tests Something related to the tests of the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant