Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trim PR title when too large for terminal in gm gh pr checkout #129

Merged
merged 3 commits into from
Dec 6, 2023
Merged

trim PR title when too large for terminal in gm gh pr checkout #129

merged 3 commits into from
Dec 6, 2023

Conversation

amtoine
Copy link
Owner

@amtoine amtoine commented Dec 5, 2023 •
edited
Loading

input list has trouble

  • scrolling when one line is too large
  • treating ANSI sequences (they match, e.g the m in \0[m)

this PR computes custom lines that are trimmed to the size of the terminal and don't use ANSI coloring 🤔

test it

  • run
tk run --interactive --sugar ["github"]
  • go to a directory with remote PR, e.g. nushell/nushell
  • run
gm gh pr checkout

@amtoine amtoine added fix A fix for a bug sugar Related to the `nu-git-manager-sugar` module labels Dec 5, 2023
@amtoine amtoine marked this pull request as ready for review December 5, 2023 18:35
@amtoine amtoine mentioned this pull request Dec 6, 2023
Open
@amtoine amtoine merged commit ea478a9 into main Dec 6, 2023
4 checks passed
@amtoine amtoine deleted the fix-pr-checkout-width branch December 6, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
fix A fix for a bug sugar Related to the `nu-git-manager-sugar` module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@amtoine