Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix the export of modules #134

Merged
merged 6 commits into from
Dec 15, 2023
Merged

fix the export of modules #134

merged 6 commits into from
Dec 15, 2023

Conversation

amtoine
Copy link
Owner

@amtoine amtoine commented Dec 9, 2023 •
edited
Loading

depends on

description

as directory modules won't export the modules next to any mod.nu, this PR adds export module calls to nu-git-manager-sugar and the tests, making the source base compatible again with nushell/nushell#11157 and nushell/nupm#47.

@amtoine amtoine added fix A fix for a bug sugar Related to the `nu-git-manager-sugar` module wait-for-upstream Need to wait for an upstream project to push some changes. labels Dec 9, 2023
@amtoine amtoine marked this pull request as ready for review December 15, 2023 11:58
@amtoine amtoine mentioned this pull request Dec 15, 2023
Merged
5 tasks
@amtoine amtoine marked this pull request as draft December 15, 2023 12:01
@amtoine amtoine changed the base branch from main to nightly December 15, 2023 12:01
@amtoine amtoine added the nightly A bleeding edge change label Dec 15, 2023
@amtoine amtoine force-pushed the fix-manual-export branch 3 times, most recently from 69dcab8 to 8bbdfeb Compare December 15, 2023 12:10
@amtoine
Copy link
Owner Author

amtoine commented Dec 15, 2023

(the force-pushes after the nightly label can be forgotten, i was just testing a bug in the CI 👀)

@amtoine
Merge branch 'nightly' into fix-manual-export
a0a5e08 
this will bring the new fixed CI from #139.
@amtoine
Merge branch 'nightly' into fix-manual-export
d667cb2 
this should solve the merge conflict in #134 and bring the changes
from #140.
@amtoine
Merge branch 'nightly' into fix-manual-export
15f02b9 
this will bring the changes from #141 and should fix the CI.
@amtoine
fix test modules rexport
cce4803
@amtoine
Copy link
Owner Author

amtoine commented Dec 15, 2023

(just did amend the last commit)

@amtoine amtoine marked this pull request as ready for review December 15, 2023 15:40
@amtoine amtoine merged commit 1262909 into nightly Dec 15, 2023
3 checks passed
@amtoine amtoine deleted the fix-manual-export branch December 15, 2023 15:41
@amtoine amtoine mentioned this pull request Dec 16, 2023
Merged
amtoine added a commit that referenced this pull request Dec 16, 2023
@amtoine
fix module exports (#147)
8dd94f3 
follow-up to
- #134

## description
- `toolkit.nu` still contained `./src/`
- there was a bad `./src/nu-git-manager/mod.nu` introduced by
#134
amtoine added a commit that referenced this pull request Jan 21, 2024
@amtoine
fix the export of modules (#134)
f359ced 
depends on
- nushell/nushell#11157
- nushell/nupm#47
- #140
- #141

## description
as directory modules won't export the modules next to any `mod.nu`, this
PR adds `export module` calls to `nu-git-manager-sugar` and the tests,
making the source base compatible again with
nushell/nushell#11157 and
nushell/nupm#47.
amtoine added a commit that referenced this pull request Jan 21, 2024
@amtoine
fix module exports (#147)
123ee54 
follow-up to
- #134

## description
- `toolkit.nu` still contained `./src/`
- there was a bad `./src/nu-git-manager/mod.nu` introduced by
#134
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
fix A fix for a bug nightly A bleeding edge change sugar Related to the `nu-git-manager-sugar` module wait-for-upstream Need to wait for an upstream project to push some changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@amtoine