Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use glob --exclude instead of glob --not #38

Merged
merged 2 commits into from
Nov 17, 2023
Merged

use glob --exclude instead of glob --not #38

merged 2 commits into from
Nov 17, 2023

Conversation

amtoine
Copy link
Owner

@amtoine amtoine commented Oct 25, 2023

related to

description

glob --not has been deprecated in nushell/nushell#10827 and will be removed in nushell/nushell#10839 before 0.88.0 in favor of glob --exclude.

this PR performs the change in nu-git-manager.

@amtoine
Copy link
Owner Author

amtoine commented Oct 25, 2023

this will need to either wait for the nightly builds to pick the latest revisions up or the next stable release.
marking as a DRAFT for now.

@amtoine amtoine marked this pull request as draft October 25, 2023 17:20
@amtoine amtoine added the fix A fix for a bug label Oct 27, 2023
@melMass melMass mentioned this pull request Oct 27, 2023
@amtoine amtoine added nightly A bleeding edge change core Related to the main `nu-git-manager` module labels Oct 28, 2023
@amtoine amtoine marked this pull request as ready for review November 5, 2023 09:15
@amtoine amtoine marked this pull request as draft November 7, 2023 17:20
@melMass melMass removed the nightly A bleeding edge change label Nov 17, 2023
@amtoine amtoine marked this pull request as ready for review November 17, 2023 21:38
@melMass melMass merged commit cedd3d2 into main Nov 17, 2023
4 checks passed
@melMass melMass deleted the use-glob-exclude branch November 17, 2023 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Related to the main `nu-git-manager` module fix A fix for a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants