Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix $.span in error make #61

Merged
merged 2 commits into from
Nov 17, 2023
Merged

fix $.span in error make #61

merged 2 commits into from
Nov 17, 2023

Conversation

amtoine
Copy link
Owner

@amtoine amtoine commented Nov 4, 2023

related to

description

with nushell/nushell#10923, error make now takes $.label.span: record<start: int, end: int> instead of $.label.start: int and $.label.end: int.
this PR prepares for the change in 0.87 😋

@amtoine amtoine added fix A fix for a bug nightly A bleeding edge change sugar Related to the `nu-git-manager-sugar` module core Related to the main `nu-git-manager` module labels Nov 4, 2023
@amtoine amtoine marked this pull request as ready for review November 5, 2023 09:16
@melMass melMass marked this pull request as draft November 6, 2023 12:12
@melMass melMass removed the nightly A bleeding edge change label Nov 17, 2023
@amtoine amtoine marked this pull request as ready for review November 17, 2023 21:38
@melMass melMass merged commit 0ce47bb into main Nov 17, 2023
3 checks passed
@melMass melMass deleted the fix-error-make branch November 17, 2023 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
core Related to the main `nu-git-manager` module fix A fix for a bug sugar Related to the `nu-git-manager-sugar` module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amtoine @melMass