Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a command to clean the store from empty directories #77

Merged
merged 19 commits into from
Nov 17, 2023
Merged

Conversation

amtoine
Copy link
Owner

@amtoine amtoine commented Nov 7, 2023

this will close #76.

this PR

  • adds the fs/dir clean-empty-directories-rec command and it's test tests store-cleaning
  • adds the gm clean command and test in tests gm store-cleaning
  • cleans the parent of any removed directory after gm remove and test that in tests gm store-cleaning-after-remove

@amtoine amtoine added bug Something isn't working as expected enhancement New feature or request core Related to the main `nu-git-manager` module labels Nov 7, 2023
@amtoine
Copy link
Owner Author

amtoine commented Nov 7, 2023

ok only one more test...

i'll become a Windows expert without ever touching the OS with all this 😆

@amtoine
Copy link
Owner Author

amtoine commented Nov 7, 2023

daaaaaaaaaaaaaaaaaaaamn 😆
finally 🥺

'twas a missing path expand because Windows was using a relative path 👀

@amtoine amtoine marked this pull request as ready for review November 7, 2023 19:14
@melMass melMass merged commit ab9fdc6 into main Nov 17, 2023
4 checks passed
@melMass melMass deleted the fix-76 branch November 17, 2023 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as expected core Related to the main `nu-git-manager` module enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gm remove does not remove empty directories
2 participants