feat: setup nightly flow #82

melMass · 2023-11-09T21:03:03Z

Text for the squash merge:

reworks the CI logic a bit and introduces the idea of the nightly branch.

execution of the CI

ci.yml will trigger as usual
- it won't run when changes are made to *.md files only
- it will trigger on all PRs and pushes to main and nightly
- it will run nupm-tests.yml
  - install Nupm with a new custom actions/setup_nupm
    main will use a pinned version (0.87 for now), nightly.... nightly.
  - run the tests of the module
in parallel, check_nightly.yml will make sure that PRs on main can be safely merged into nightly
finally, only when a PR on main is closed, the new main branch will be merged into nightly

TODO

a dedicated action for setup_nupm, could be used in other jobs later.
on pushes in PRs targeting main a new step is checked mergeable in nightly
on merge of PRs targeting main, main is automatically merged to nightly.

melMass · 2023-11-09T21:04:20Z

Mmm for some reason it doesn't run the CI 🤣

ci.yml is the entry point

might be a context thing?

This still needs further work and testing but the idea is there. A few ideas I want to finish: - use an explicit nushell version for the release tests. for now it uses "*" which is latest release. - thanks to the previous point we can cache installs. - for this logic to be sane main should be locked and only accept PR

amtoine

first: review on the main ci.yml => it looks great 🥳

i'll just push minor refactors and i have a few small questions 😌

then i'll review the two others 😏

.github/workflows/ci.yml

.github/workflows/nupm-tests.yml

.github/actions/setup_nupm/action.yml

amtoine

i also have a few questions on the two new main actions 😉

.github/workflows/check_nightly.yml

.github/actions/sync_action/action.yml

amtoine · 2023-11-13T18:20:20Z

Important
the few force-pushes above were solely to make my pure-refactoring changes fit into one commit 😉

let's see if it works, it's much less readable 😅

melMass · 2023-11-13T20:09:37Z

Important
I reverted "make the tests manually triggerable" since it will be once merged I believe (and it broke the CI)

Not sure any output is needed if we use an input now

melMass · 2023-11-14T17:58:36Z

There is just one thing we need to do before merge btw! (Add write rights for now push will fail)

amtoine · 2023-11-14T18:00:29Z

There is just one thing we need to do before merge btw! (Add write rights for now push will fail)

okey, you wanna do that?

there is a single thread missing, i don't know the syntax nor where to search for documentation for it 👀

melMass · 2023-11-14T18:08:24Z

It's just a matter of using the builtin GitHub token I think, I will give it a quick look tonight

This reverts commit a759195.

This reverts commit 9b09dd3.

This reverts commit ca193c0.

amtoine · 2023-11-15T18:42:14Z

Note
i've left the commits above (from 71168be to b3b7ac8 included) to show that i couldn't get #82 (comment) to work 😢

This reverts commit 2a33119.

amtoine · 2023-11-15T19:06:21Z

Note
same here, the last two commits are a failed attempt to apply actions/runner#409 (comment)

more info here: hustcer/setup-nu#67

amtoine

thanks @melMass for working on this, really much appreciated 🙏

let's land this PR and see how it goes 😇 🤞

for both the *dry* check and the real sync, the GitHub action needs to be able to perform a merge. for this Git needs to be setup, otherwise the runner cannot commit and create the merge commit, which [crashed the CI](https://github.com/amtoine/nu-git-manager/actions/runs/6905039750) after #82. this PR - moves the Git setup before the *merge* step - always sets up Git, regardless of the value of `do_push` and `$env.ACT`

ci: 🚀 just pushing my local things

b09837b

melMass changed the base branch from main to nightly November 9, 2023 21:03

melMass changed the base branch from nightly to main November 9, 2023 21:03

melMass marked this pull request as ready for review November 9, 2023 21:10

melMass added 5 commits November 9, 2023 22:13

ci: 💄 typo

feed1bc

ci: ✨ use reusable workflow

273ae1b

ci.yml is the entry point

ci: 💄 typo

a75c9e3

ci: 🚧 quotes?

6d07dc0

ci: ✨ use nu to clone

0410914

might be a context thing?

melMass marked this pull request as draft November 9, 2023 22:41

melMass added 3 commits November 12, 2023 16:46

fix: 🐛 inputs in composite actions are evaluated as string it seems

ec12547

ci: 🎨 rename job/step

2b08060

melMass marked this pull request as ready for review November 12, 2023 15:57

amtoine reviewed Nov 13, 2023

View reviewed changes

.github/workflows/ci.yml Show resolved Hide resolved

.github/workflows/nupm-tests.yml Outdated Show resolved Hide resolved

.github/actions/setup_nupm/action.yml Show resolved Hide resolved

.github/actions/setup_nupm/action.yml Outdated Show resolved Hide resolved

amtoine force-pushed the ci/setup_nightly_flow branch 2 times, most recently from 54e4020 to 8baafd0 Compare November 13, 2023 18:08

minor refactoring

01b971d

amtoine force-pushed the ci/setup_nightly_flow branch from 8baafd0 to 01b971d Compare November 13, 2023 18:19

amtoine reviewed Nov 13, 2023

View reviewed changes

.github/workflows/check_nightly.yml Show resolved Hide resolved

.github/workflows/check_nightly.yml Outdated Show resolved Hide resolved

.github/actions/sync_action/action.yml Show resolved Hide resolved

.github/actions/sync_action/action.yml Show resolved Hide resolved

melMass added 2 commits November 13, 2023 20:34

ci: ✨ test

8c29b62

let's see if it works, it's much less readable 😅

fix: ✨ quote paths

d1cc0f0

melMass force-pushed the ci/setup_nightly_flow branch from 0af2c8e to d1cc0f0 Compare November 13, 2023 20:08

fix: 🎨 at least use the proper path

6030fbe

Not sure any output is needed if we use an input now

amtoine added 5 commits November 15, 2023 19:34

use Nupm in separate step

a759195

Revert "use Nupm in separate step"

851edaa

This reverts commit a759195.

Revert "try to use from inside setup-nupm"

0ec592c

This reverts commit 9b09dd3.

try to use the nupm-path from setup_nupm

ca193c0

Revert "try to use the nupm-path from setup_nupm"

b3b7ac8

This reverts commit ca193c0.

refactor a bit the Nupm install

b14418b

amtoine force-pushed the ci/setup_nightly_flow branch from 03afd00 to 4e752d3 Compare November 15, 2023 19:00

try to merge latest / nightly Nupm setup steps

2a33119

amtoine force-pushed the ci/setup_nightly_flow branch from 4e752d3 to 2a33119 Compare November 15, 2023 19:02

Revert "try to merge latest / nightly Nupm setup steps"

c8f18b6

This reverts commit 2a33119.

amtoine added 2 commits November 16, 2023 18:32

fix the Nushell version to 0.87.0

fe17c36

fix the Nupm version to f7c0843

cb83ae5

amtoine added ci Something related to the Continuous Integration dev Related to the dev experience labels Nov 16, 2023

melMass added 4 commits November 17, 2023 00:58

ci: ✨ merge steps

eb2577c

ci: 🚀 use output

20c9ca4

ci: 🐛 GITHUB_OUTPUT is a "file" not an env

ffcbdba

fix: 🎨 use proper path...

96a0fdc

melMass requested a review from amtoine November 17, 2023 00:51

melMass added 4 commits November 17, 2023 02:03

refactor: 💄 remove extra uppercases

644ad7f

ci: 🔥 try to remove extra fetch args

e349c2f

ci: 🔐 avoid rate limits when downloading nushell releases.

dafc62a

more info here: hustcer/setup-nu#67

ci: 🚑️ set env from workflow

8d95762

amtoine approved these changes Nov 17, 2023

View reviewed changes

amtoine merged commit 390d25d into main Nov 17, 2023
4 checks passed

amtoine deleted the ci/setup_nightly_flow branch November 17, 2023 14:10

amtoine mentioned this pull request Nov 17, 2023

fix the sync CI #86

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: setup nightly flow #82

feat: setup nightly flow #82

melMass commented Nov 9, 2023 •

edited

Loading

melMass commented Nov 9, 2023

amtoine left a comment

amtoine left a comment

amtoine commented Nov 13, 2023

melMass commented Nov 13, 2023 •

edited

Loading

melMass commented Nov 14, 2023

amtoine commented Nov 14, 2023

melMass commented Nov 14, 2023 •

edited

Loading

amtoine commented Nov 15, 2023

amtoine commented Nov 15, 2023

amtoine left a comment

feat: setup nightly flow #82

feat: setup nightly flow #82

Conversation

melMass commented Nov 9, 2023 • edited Loading

Text for the squash merge:

TODO

melMass commented Nov 9, 2023

amtoine left a comment

Choose a reason for hiding this comment

amtoine left a comment

Choose a reason for hiding this comment

amtoine commented Nov 13, 2023

melMass commented Nov 13, 2023 • edited Loading

melMass commented Nov 14, 2023

amtoine commented Nov 14, 2023

melMass commented Nov 14, 2023 • edited Loading

amtoine commented Nov 15, 2023

amtoine commented Nov 15, 2023

amtoine left a comment

Choose a reason for hiding this comment

melMass commented Nov 9, 2023 •

edited

Loading

melMass commented Nov 13, 2023 •

edited

Loading

melMass commented Nov 14, 2023 •

edited

Loading