Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails with missing "shell integration" field on Nushell 0.93.1 #64

Closed
kubouch opened this issue May 25, 2024 · 6 comments · Fixed by #68
Closed

Fails with missing "shell integration" field on Nushell 0.93.1 #64

kubouch opened this issue May 25, 2024 · 6 comments · Fixed by #68
Labels
bug Something isn't working

Comments

@kubouch
Copy link

kubouch commented May 25, 2024

related to

I get this error on Nushell 0.93.1 (latest main):

> $nu | nu_plugin_explore
Plugin `explore` error: Plugin failed to decode: missing field `shell_integration`
Error: nu::shell::plugin_failed_to_decode

  × Plugin failed to decode: missing field `shell_integration`

version | transpose key value | to md --pretty

key value
version 0.93.1
major 0
minor 93
patch 1
branch main
commit_hash bf07806b1bc96eebcaa57456c97035a6bce68ef7
build_os linux-x86_64
build_target x86_64-unknown-linux-gnu
rust_version rustc 1.77.2 (25ef9e3d8 2024-04-09)
rust_channel 1.77.2-x86_64-unknown-linux-gnu
cargo_version cargo 1.77.2 (e52e36006 2024-03-26)
build_time 2024-05-24 09:44:08 +03:00
build_rust_channel release
allocator mimalloc
features default, sqlite, system-clipboard, trash, which
installed_plugins formats, gstat, highlight, inc, polars, query
@amtoine amtoine added the bug Something isn't working label May 26, 2024
@amtoine
Copy link
Owner

amtoine commented May 26, 2024

thanks for reporting, i can actually reproduce this with nushell/nushell@ac4125f

@amtoine
Copy link
Owner

amtoine commented May 26, 2024

ok, it's working with Nushell 0.93.0, so something happened in Nushell between nushell/nushell@3b220e07e and nushell/nushell@ac4125f8e

@amtoine
Copy link
Owner

amtoine commented May 26, 2024

bisecting Nushell... ♻️

so looong to compile on my personal machine 💀

@amtoine
Copy link
Owner

amtoine commented May 26, 2024

@amtoine
Copy link
Owner

amtoine commented May 26, 2024

i was able to fix the issue by compiling the plugin with the same revision as my Nushell install, i.e. nushell/nushell@ac4125f, and the following TOML

nuon = { git = "https://github.com/nushell/nushell", rev = "ac4125f8edd5b8f3f68aa653d03d57b2d25f1da1", package = "nuon" }
nu-plugin = { git = "https://github.com/nushell/nushell", rev = "ac4125f8edd5b8f3f68aa653d03d57b2d25f1da1", package = "nu-plugin" }
nu-protocol = { git = "https://github.com/nushell/nushell", rev = "ac4125f8edd5b8f3f68aa653d03d57b2d25f1da1", package = "nu-protocol", features = ["plugin"] }

instead of

nuon = "0.93.0"
nu-plugin = "0.93.0"
nu-protocol = "0.93.0"

@kubouch, could you try with the same rev as the output of (version).commit_hash? 😇

Note
i'm using nushell/nushell@ac4125 because it contains a both the "shell integration" PR and a fix around completion

@amtoine
Copy link
Owner

amtoine commented May 26, 2024

@kubouch you can also have a look at the new "troubleshooting" section of the README, and make sure you are on the latest main, there was a bug in the deps.nu module

@amtoine amtoine mentioned this issue Jun 1, 2024
amtoine added a commit that referenced this issue Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants