This repository has been archived by the owner on Oct 18, 2021. It is now read-only.
Quick Look Impredicativity #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lets us infer /some/ uses of impredicative types.
added 2 commits
October 19, 2019 00:46
SquidDev
suggested changes
Oct 19, 2019
| pure $ fromMaybe mempty (unifyPure result tau) | ||
| _ -> pure mempty | ||
|
|
||
| #ifdef TRACE_TC |
There was a problem hiding this comment.
Is it worth refactoring the trace code from Types.Unify into a Types.Trace module? Then we can share it everywhere, rather than using the CPP in some places, and not in others.
There was a problem hiding this comment.
No: this lets us individually control which modules to trace. Kinda sad, though
SquidDev
approved these changes
Oct 19, 2019
plt-amy
pushed a commit
that referenced
this pull request
Jan 12, 2020
This lets us infer /some/ uses of impredicative types.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets us infer /some/ uses of impredicative types.