Skip to content
This repository has been archived by the owner on Oct 18, 2021. It is now read-only.

Feature: 'include' statement #207

Merged
merged 2 commits into from
Oct 25, 2019
Merged

Feature: 'include' statement #207

merged 2 commits into from
Oct 25, 2019

Conversation

plt-amy
Copy link
Member

@plt-amy plt-amy commented Oct 25, 2019

include is exactly as open except the signature of the included module is concatenated with the signature of the including module. Concretely:

module X : sig val x : int end = begin
  let x = 1
end

module Y = (begin
  let y = 1
  include X
end) : sig
  val x : int
  val y : int
end

@plt-amy plt-amy requested a review from SquidDev October 25, 2019 17:17
@plt-amy plt-amy added the Yet Another Module System Issues/PRs relating to YAMS label Oct 25, 2019
Copy link
Member

@SquidDev SquidDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny thing, but otherwise looks good.

@plt-amy plt-amy dismissed SquidDev’s stale review October 25, 2019 17:32

I REJECT MY REVIEW, JOJO!

@plt-amy plt-amy merged commit 424b24a into master Oct 25, 2019
@plt-amy plt-amy deleted the feature/include-mod branch October 25, 2019 17:33
plt-amy pushed a commit that referenced this pull request Jan 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Yet Another Module System Issues/PRs relating to YAMS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants