This repository has been archived by the owner on Oct 18, 2021. It is now read-only.
Module caching #211
Merged
Module caching #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plt-amy
force-pushed
the
feature/cache
branch
from
7128409 to
0b75c21
Compare
Doesn't support minor updates (ticks) yet, but it's a good enough start. In need of a lot of testing.
Most importantly, this allows us to reattempt compilation of erroring files on each new REPL input, which makes the workflow much easier.
- Make Driver.compile take a list of files to compile instead, and use that for loading files within the REPL. This prevents us from running the prelude twice. - Be more selective in what driver state we reset - make resetting opt-in rather than opt out. This fixes several issues with fresh name generation.
Note to self: don't just compile within the REPL
plt-amy
force-pushed
the
feature/cache
branch
from
ec608af to
b2a3579
Compare
plt-amy
approved these changes
Oct 30, 2019
plt-amy
pushed a commit
that referenced
this pull request
Jan 12, 2020
- The driver now has a "clock", with a major and minor counter.
- Counters are used to mark places where we expect loaded files to
change. Otherwise you may have a file change between a call to
`getSignature` and `getLowered`, which is terribly confusing.
- Ticks (minor updates), allow non-emitted files to be reloaded if
they have changed. This means you can reimport erroring files
within the repl, and we will attempt recompilation.
- Tocks (major updates), reloads any changed file. This is only
done when using `:[re]load`, as you need to throw away any existing
values at the same time.
- The REPL now keeps the same driver around for the whole session,
ticking and tocking it where appropriate.
- Files are considered to have changed if their SHA256 hash has changed,
or any of their dependencies have changed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the design as discussed in #183:
getSignatureandgetLowered, which is terribly confusing.:[re]load, as you need to throw away any existing values at the same time.It's worth noting that the REPL is still a little slow to run after each
:r, as we still need to emit and run the appropriate Lua code, which takes a bit of time. It might be possible to defer the running of non-critical Lua code, but doing so is a much harder challenge.Edit: Actually, it's not as bad as I thought it was - just tried it outside of ghci, and the performance is fine, so it probably isn't down to Lua.