Setting default passwords properly

amun-ai · Feb 2, 2024 · 177c177 · 177c177
1 parent f5fd179
commit 177c177
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 8 deletions.
diff --git a/charts/hypha/charts/tritoninferenceserver-hypha-1.0.10.tgz b/charts/hypha/charts/tritoninferenceserver-hypha-1.0.10.tgz
diff --git a/charts/hypha/templates/deployment.yaml b/charts/hypha/templates/deployment.yaml
@@ -73,12 +73,19 @@ spec:
             --enable-s3 \
             --endpoint-url=http://{{ .Values.minio.fullnameOverride }}:{{.Values.minio.service.port}} \
             --endpoint-url-public={{ $S3_ENDPOINT_URL_PUBLIC }} \
-            --access-key-id="{{ $S3_ACCESS_KEY }}" \
-            --secret-access-key="{{ $S3_SECRET_KEY }}" \
+            --access-key-id="{{ .Values.minio.rootUser }}" \
+            --secret-access="{{ .Values.minio.rootPassword }}" \
             --executable-path={{ .Values.executablePath }} \
             --enable-server-apps \
             --apps-dir={{ .Values.appsDir }} \
             --public-base-url={{ .Values.hyphaHostName }} \
+
+            
+#  TODO add option for non minio s3
+
+
+        # --access-key-id="{{ $S3_ACCESS_KEY }}" \
+        # --secret-access-key="{{ $S3_SECRET_KEY }}" \
         # --reset-redis \
         # --startup-functions={{ .Values.startupFunctionsPath }}:hypha_startup \
         # --in-docker \

diff --git a/charts/hypha/values.yaml b/charts/hypha/values.yaml
@@ -24,7 +24,7 @@ image:
   pullPolicy: IfNotPresent
   tag: "0.15.35"
 
-triton_url: "http://tritoninferenceserver.tritoninferenceserver.svc.cluster.local:8000"
+triton_url: "http://tritoninferenceserver"
 
 service:
   type: ClusterIP
@@ -59,25 +59,22 @@ redis:
   enabled: enabled
   global:
     redis:
-      password: "admin"
+      password: "redis-password"
 
 docker-registry:
   enabled: false
 
 minio:
-  # nameOverride: "minio"
   fullnameOverride: "minio"
   enabled: true
   rootUser: "minio"
-  rootPassword: "xZ/aDcP+PfoTWgwA9ZADTtU/+djwMeMKz4QlSKRcgEs="
+  rootPassword: "minio123"
   publicEndpointUrl: ""
   browserRedirectUrl: ""
 
   replicas: 4
   ingress:
     enabled: true
-    # hosts:
-    # - hs3.imjoy.io
   resources:
     requests:
       memory: 2Gi