Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

frontend: upgrade react-bootstrap from 0.x to 1.x #818

Closed
dorianj opened this issue Nov 20, 2020 · 2 comments
Closed

frontend: upgrade react-bootstrap from 0.x to 1.x #818

dorianj opened this issue Nov 20, 2020 · 2 comments
Labels
status:abandoned Issue we won’t go ahead and implement, or that needs a “champion” to take it through

Comments

@dorianj
Copy link
Contributor

dorianj commented Nov 20, 2020

Expected Behavior

While working on #794, I noticed that we're on an outdated version of react-bootstrap, and it's causing a variety of deprecation warnings during compilation. The new version is a breaking release with extensive backwards-incompatible changes. Because it's visual, there's a good chance that test coverage will not catch regressions, so complete manual testing with a valid dataset is suggested to ensure no breakages.

There is a guide at https://react-bootstrap.github.io/migrating/
@dorianj dorianj mentioned this issue Nov 20, 2020
Merged
5 tasks
Golodhros pushed a commit to amundsen-io/amundsenfrontendlibrary that referenced this issue Nov 23, 2020
@dorianj
chore: build: upgrade webpack from 4 to 5 (#770)
de566e5 
* app node_modules: upgrade webpack to 4->5

Signed-off-by: Dorian Johnson <2020@dorianj.net>

* package.json: install path-browserify

Needed by react-markdown as of 5.0.2

Signed-off-by: Dorian Johnson <2020@dorianj.net>

* webpack: use polyfill for path

Signed-off-by: Dorian Johnson <2020@dorianj.net>

* webpack: add hack to make old react-bootstrap work

Signed-off-by: Dorian Johnson <2020@dorianj.net>

* package.json: upgrade html-webpack-plugin 4 -> 4.5.0

Signed-off-by: Dorian Johnson <2020@dorianj.net>

* package.json: upgrade mini-css-extract-plugin 0.10 -> 0.12

Fixes many webpack deprecation warnings.

Signed-off-by: Dorian Johnson <2020@dorianj.net>

* webpack: fix deprecation warning in moduleIds optimization

Signed-off-by: Dorian Johnson <2020@dorianj.net>

* webpack: link hacky behavior to ticket

amundsen-io/amundsen#818

Signed-off-by: Dorian Johnson <2020@dorianj.net>
@Golodhros
Copy link
Member

Hi @dorianj,

Yeah, we are aware of this, but we decided to eventually move out of react-bootstrap overall.

We are preparing a component library for Amundsen and other products at Lyft, and we want to use that once we manage to open source it (hopefully soon!).

@Golodhros Golodhros added Project: Frontend status:abandoned Issue we won’t go ahead and implement, or that needs a “champion” to take it through labels Dec 2, 2020
@dorianj
Copy link
Contributor Author

dorianj commented Dec 2, 2020

oh, nice, that's even better

dorianj added a commit to dorianj/amundsen that referenced this issue Apr 25, 2021
@dorianj
chore: build: upgrade webpack from 4 to 5 (amundsen-io#770)
4461e4f 
* app node_modules: upgrade webpack to 4->5

Signed-off-by: Dorian Johnson <2020@dorianj.net>

* package.json: install path-browserify

Needed by react-markdown as of 5.0.2

Signed-off-by: Dorian Johnson <2020@dorianj.net>

* webpack: use polyfill for path

Signed-off-by: Dorian Johnson <2020@dorianj.net>

* webpack: add hack to make old react-bootstrap work

Signed-off-by: Dorian Johnson <2020@dorianj.net>

* package.json: upgrade html-webpack-plugin 4 -> 4.5.0

Signed-off-by: Dorian Johnson <2020@dorianj.net>

* package.json: upgrade mini-css-extract-plugin 0.10 -> 0.12

Fixes many webpack deprecation warnings.

Signed-off-by: Dorian Johnson <2020@dorianj.net>

* webpack: fix deprecation warning in moduleIds optimization

Signed-off-by: Dorian Johnson <2020@dorianj.net>

* webpack: link hacky behavior to ticket

amundsen-io#818

Signed-off-by: Dorian Johnson <2020@dorianj.net>
dorianj pushed a commit to dorianj/amundsen that referenced this issue Apr 25, 2021
@dependabot-preview
build(deps): [security] bump ini in /amundsen_application/static (amu…
58d5aa8 
…ndsen-io#818)

Bumps [ini](https://github.com/isaacs/ini) from 1.3.5 to 1.3.7. **This update includes a security fix.**
- [Release notes](https://github.com/isaacs/ini/releases)
- [Commits](npm/ini@v1.3.5...v1.3.7)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
feng-tao pushed a commit that referenced this issue May 7, 2021
@dorianj
chore: build: upgrade webpack from 4 to 5 (#770)
00b6e51 
* app node_modules: upgrade webpack to 4->5

Signed-off-by: Dorian Johnson <2020@dorianj.net>

* package.json: install path-browserify

Needed by react-markdown as of 5.0.2

Signed-off-by: Dorian Johnson <2020@dorianj.net>

* webpack: use polyfill for path

Signed-off-by: Dorian Johnson <2020@dorianj.net>

* webpack: add hack to make old react-bootstrap work

Signed-off-by: Dorian Johnson <2020@dorianj.net>

* package.json: upgrade html-webpack-plugin 4 -> 4.5.0

Signed-off-by: Dorian Johnson <2020@dorianj.net>

* package.json: upgrade mini-css-extract-plugin 0.10 -> 0.12

Fixes many webpack deprecation warnings.

Signed-off-by: Dorian Johnson <2020@dorianj.net>

* webpack: fix deprecation warning in moduleIds optimization

Signed-off-by: Dorian Johnson <2020@dorianj.net>

* webpack: link hacky behavior to ticket

#818

Signed-off-by: Dorian Johnson <2020@dorianj.net>
feng-tao pushed a commit that referenced this issue May 7, 2021
@dependabot-preview
build(deps): [security] bump ini in /amundsen_application/static (#818)
8bd55fa 
Bumps [ini](https://github.com/isaacs/ini) from 1.3.5 to 1.3.7. **This update includes a security fix.**
- [Release notes](https://github.com/isaacs/ini/releases)
- [Commits](npm/ini@v1.3.5...v1.3.7)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
zacr pushed a commit to SaltIO/amundsen that referenced this issue May 13, 2022
@dorianj
chore: build: upgrade webpack from 4 to 5 (amundsen-io#770)
961968c 
* app node_modules: upgrade webpack to 4->5

Signed-off-by: Dorian Johnson <2020@dorianj.net>

* package.json: install path-browserify

Needed by react-markdown as of 5.0.2

Signed-off-by: Dorian Johnson <2020@dorianj.net>

* webpack: use polyfill for path

Signed-off-by: Dorian Johnson <2020@dorianj.net>

* webpack: add hack to make old react-bootstrap work

Signed-off-by: Dorian Johnson <2020@dorianj.net>

* package.json: upgrade html-webpack-plugin 4 -> 4.5.0

Signed-off-by: Dorian Johnson <2020@dorianj.net>

* package.json: upgrade mini-css-extract-plugin 0.10 -> 0.12

Fixes many webpack deprecation warnings.

Signed-off-by: Dorian Johnson <2020@dorianj.net>

* webpack: fix deprecation warning in moduleIds optimization

Signed-off-by: Dorian Johnson <2020@dorianj.net>

* webpack: link hacky behavior to ticket

amundsen-io#818

Signed-off-by: Dorian Johnson <2020@dorianj.net>
zacr pushed a commit to SaltIO/amundsen that referenced this issue May 13, 2022
@dependabot-preview
build(deps): [security] bump ini in /amundsen_application/static (amu…
08af03e 
…ndsen-io#818)

Bumps [ini](https://github.com/isaacs/ini) from 1.3.5 to 1.3.7. **This update includes a security fix.**
- [Release notes](https://github.com/isaacs/ini/releases)
- [Commits](npm/ini@v1.3.5...v1.3.7)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
hansadriaans pushed a commit to DataChefHQ/amundsen that referenced this issue Jun 30, 2022
@dorianj
chore: build: upgrade webpack from 4 to 5 (amundsen-io#770)
10f1458 
* app node_modules: upgrade webpack to 4->5

Signed-off-by: Dorian Johnson <2020@dorianj.net>

* package.json: install path-browserify

Needed by react-markdown as of 5.0.2

Signed-off-by: Dorian Johnson <2020@dorianj.net>

* webpack: use polyfill for path

Signed-off-by: Dorian Johnson <2020@dorianj.net>

* webpack: add hack to make old react-bootstrap work

Signed-off-by: Dorian Johnson <2020@dorianj.net>

* package.json: upgrade html-webpack-plugin 4 -> 4.5.0

Signed-off-by: Dorian Johnson <2020@dorianj.net>

* package.json: upgrade mini-css-extract-plugin 0.10 -> 0.12

Fixes many webpack deprecation warnings.

Signed-off-by: Dorian Johnson <2020@dorianj.net>

* webpack: fix deprecation warning in moduleIds optimization

Signed-off-by: Dorian Johnson <2020@dorianj.net>

* webpack: link hacky behavior to ticket

amundsen-io#818

Signed-off-by: Dorian Johnson <2020@dorianj.net>
hansadriaans pushed a commit to DataChefHQ/amundsen that referenced this issue Jun 30, 2022
@dependabot-preview
build(deps): [security] bump ini in /amundsen_application/static (amu…
06f8e54 
…ndsen-io#818)

Bumps [ini](https://github.com/isaacs/ini) from 1.3.5 to 1.3.7. **This update includes a security fix.**
- [Release notes](https://github.com/isaacs/ini/releases)
- [Commits](npm/ini@v1.3.5...v1.3.7)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status:abandoned Issue we won’t go ahead and implement, or that needs a “champion” to take it through
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Golodhros @dorianj