Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-fill in column description based on criteria #870

Closed
markgrover opened this issue Jan 7, 2021 · 3 comments
Closed

Auto-fill in column description based on criteria #870

markgrover opened this issue Jan 7, 2021 · 3 comments

Comments

@markgrover
Copy link
Contributor

markgrover commented Jan 7, 2021

Expected Behavior or Use Case

Often times, there are cases where a column may exist across multiple tables, but it always means and represents the same thing. For example, at Lyft, all event tables had a created_at column that tracked the time when the event record was created.
Such columns in all event tables would have same description. Description is still useful because it can be event time or processing time and describing that was important. Another example is a partition column like ds or dt, and documenting that is useful and applies across multiple tables.

Service or Ingestion ETL

Metadata service

Possible Implementation

From a user-experience perspective,
Scrappy Option #1 is to apply programmatic descriptions on all columns with a certain name or a certain tag.
Scrappy Option #2 is to make the descriptions (regular descriptions, not programmatic ones) read-only for such columns and have this hard-coded description be the read-only description.
Scrappy Option #3 is to seed the description with a hard-coded description based on a criteria.
In a scrappy version, the description would be hardcoded and applied in neo4j. Over the longer term, we could build an experience for such descriptions in a data dictionary.

  • You define a term in the dictionary say "created_at".
  • Set the description there.
  • Apply that term to any column that follows a pattern (e.g. any column named created_at in tables under schema events)
  • Apply the term's description to the associated columns.

Example Screenshots (if appropriate):

Context

More details: https://amundsenworkspace.slack.com/archives/CGFBVT23V/p1609999194249500

@markgrover
Copy link
Contributor Author

From Tao, you could apply a transformer in the databuilder to set this kind of rule (e.g if column == ‘created_at’ , the description = xxx) so this issue is more of a long term thing since the suggested short term solution works. It's option #3 above.

@markgrover markgrover reopened this Jan 14, 2021
dorianj pushed a commit to dorianj/amundsen that referenced this issue Apr 25, 2021
Bumps [pytest-cov](https://github.com/pytest-dev/pytest-cov) from 2.5.1 to 2.11.0.
- [Release notes](https://github.com/pytest-dev/pytest-cov/releases)
- [Changelog](https://github.com/pytest-dev/pytest-cov/blob/master/CHANGELOG.rst)
- [Commits](pytest-dev/pytest-cov@v2.5.1...v2.11.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
@stale
Copy link

stale bot commented May 6, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale label May 6, 2021
feng-tao pushed a commit that referenced this issue May 7, 2021
Bumps [pytest-cov](https://github.com/pytest-dev/pytest-cov) from 2.5.1 to 2.11.0.
- [Release notes](https://github.com/pytest-dev/pytest-cov/releases)
- [Changelog](https://github.com/pytest-dev/pytest-cov/blob/master/CHANGELOG.rst)
- [Commits](pytest-dev/pytest-cov@v2.5.1...v2.11.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
@stale
Copy link

stale bot commented May 28, 2021

This issue has been automatically closed for inactivity. If you still wish to make these changes, please open a new pull request or reopen this one.

@stale stale bot closed this as completed May 28, 2021
zacr pushed a commit to SaltIO/amundsen that referenced this issue May 13, 2022
Bumps [pytest-cov](https://github.com/pytest-dev/pytest-cov) from 2.5.1 to 2.11.0.
- [Release notes](https://github.com/pytest-dev/pytest-cov/releases)
- [Changelog](https://github.com/pytest-dev/pytest-cov/blob/master/CHANGELOG.rst)
- [Commits](pytest-dev/pytest-cov@v2.5.1...v2.11.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
hansadriaans pushed a commit to DataChefHQ/amundsen that referenced this issue Jun 30, 2022
Bumps [pytest-cov](https://github.com/pytest-dev/pytest-cov) from 2.5.1 to 2.11.0.
- [Release notes](https://github.com/pytest-dev/pytest-cov/releases)
- [Changelog](https://github.com/pytest-dev/pytest-cov/blob/master/CHANGELOG.rst)
- [Commits](pytest-dev/pytest-cov@v2.5.1...v2.11.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant