Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improve handling missing values in atlas search extractor #1172

Closed
wants to merge 1 commit into from

Conversation

mgorsk1
Copy link
Contributor

@mgorsk1 mgorsk1 commented May 31, 2021

Summary of Changes

As atlas client might return None instead of empty list in relationship attributes, handling of such scenarios needs to be improved.

Tests

n/a

Documentation

n/a

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does

Signed-off-by: mgorsk1 <gorskimariusz13@gmail.com>
@mgorsk1 mgorsk1 requested a review from a team as a code owner May 31, 2021 06:23
@boring-cyborg boring-cyborg bot added the area:databuilder From databuilder folder label May 31, 2021
@mgorsk1 mgorsk1 changed the title other: Improve handling missing values in atlas search extractor feat: Improve handling missing values in atlas search extractor May 31, 2021
@mgorsk1
Copy link
Contributor Author

mgorsk1 commented Jun 1, 2021

closed over #1180

@mgorsk1 mgorsk1 closed this Jun 1, 2021
@feng-tao feng-tao deleted the feat/improve_atlas_search_extractor branch June 3, 2021 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:databuilder From databuilder folder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant