feat: Add feature discovery route and page #1185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danwom
requested review from
allisonsuarez,
dikshathakur3119,
dorianj,
feng-tao,
Golodhros and
ttannis
as code owners
Golodhros
reviewed
Jun 2, 2021
frontend/amundsen_application/static/js/pages/FeaturePage/index.tsx
Outdated
Show resolved
Hide resolved
Golodhros
reviewed
Jun 2, 2021
| <article className="column-layout-1"> | ||
| <aside className="left-panel"> | ||
| <section className="metadata-section"> | ||
| <div className="section-title title-3">Description</div> |
There was a problem hiding this comment.
Let's use the new title styles, and a semantic tag.
Golodhros
reviewed
Jun 2, 2021
| <section className="column-layout-2"> | ||
| <section className="left-panel"> | ||
| <section className="metadata-section"> | ||
| <div className="section-title title-3">Entity</div> |
Golodhros
reviewed
Jun 2, 2021
| {feature.entity} | ||
| </section> | ||
| <section className="metadata-section"> | ||
| <div className="section-title title-3">Data Type</div> |
There was a problem hiding this comment.
and in the rest of elements like this one
danwom
changed the title
added 3 commits
June 4, 2021 02:35
Signed-off-by: Daniel Won <dwon@lyft.com>
Signed-off-by: Daniel Won <dwon@lyft.com>
- Code cleanup Signed-off-by: Daniel Won <dwon@lyft.com>
danwom
force-pushed
the
dwon-feature-discovery-route
branch
from
dc59a5e to
03fe676
Compare
Golodhros
approved these changes
Jun 4, 2021
- Removed 'prefer-promise-reject-errors' betterer rule Signed-off-by: Daniel Won <dwon@lyft.com>
Golodhros
reviewed
Jun 9, 2021
| } | ||
|
|
||
| .shimmer-page-subtitle { | ||
| height: 18px; |
There was a problem hiding this comment.
nit: could we use some variables for the heights?
Signed-off-by: Daniel Won <dwon@lyft.com>
allisonsuarez
pushed a commit
that referenced
this pull request
Jun 11, 2021
* Added redux boilerplate for feature Signed-off-by: Daniel Won <dwon@lyft.com> * Add feature page basics Signed-off-by: Daniel Won <dwon@lyft.com> * - Added feature as a resource type - Code cleanup Signed-off-by: Daniel Won <dwon@lyft.com> * Add loading state for feature page - Removed 'prefer-promise-reject-errors' betterer rule Signed-off-by: Daniel Won <dwon@lyft.com> * Add tests to feature ducks Signed-off-by: Daniel Won <dwon@lyft.com> Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
allisonsuarez
added a commit
that referenced
this pull request
Jun 15, 2021
* feat: Merge feature discovery work into protected branch (#1153) * bump up databuilder version to 4.4.1 (#1130) Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * feat: FE ML Feature get_feature_metadata (#1147) * functional API for feature details Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * lint Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * starting unit tests Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * changed naming Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * correct feat key Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * oopsie Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * mock data Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * removed stuff Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * expected metadata Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * tests should work now Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * oopies pt 2 Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * all unit tests Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * lint Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * format string Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * chore: remove a comment that conflicts with implementation (#1154) Signed-off-by: Tero Paananen <tpaananen@bloomberg.net> * feat: ML Feature Lineage (#1156) * funtional Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * unit tests Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * lint Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * 404 case and id Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> Co-authored-by: Junda Yang <youngyjd@gmail.com> Co-authored-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> Co-authored-by: Allison Suarez Miranda <22477579+allisonsuarez@users.noreply.github.com> Co-authored-by: gorbachev <tpp+github@iki.fi> Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * chore: get latest code from main (#1181) * chore: remove a comment that conflicts with implementation (#1154) Signed-off-by: Tero Paananen <tpaananen@bloomberg.net> * feat: Common query models (#1155) * Added join and where models for how tables are joined / filtered with sql Signed-off-by: Grant Seward <grant@stemma.ai> * removed addl space Signed-off-by: Grant Seward <grant@stemma.ai> * version bump Signed-off-by: Grant Seward <grant@stemma.ai> * feat: Configuration option to init custom routes (#1160) * configuration option to init custom routes Signed-off-by: verdan <verdan.mahmood@gmail.com> * Fixes isort Signed-off-by: verdan <verdan.mahmood@gmail.com> * :sigh: really fixes isort Signed-off-by: verdan <verdan.mahmood@gmail.com> * feat: Search service adding suport for AWS Elasticsearch (#1141) Signed-off-by: Jakub Nowacki <j.s.nowacki@gmail.com> * Fix installation link (#1159) The link was broken Signed-off-by: Fokko Driesprong <fokko@datafold.com> * fix: 1157 issude - metadata sql alchemy for iodc component (#1169) Signed-off-by: iamtodor <todor.ilya@gmail.com> * Helm service versions moved up to latest ones (#1165) Signed-off-by: Jakub Nowacki <j.s.nowacki@gmail.com> * Fix doc links in README.md (#1164) Just a quick driveby to fix a few doc links that still point to old locations. Signed-off-by: James Davidheiser <jamesdavidheiser@asana.com> * fix: aws_config (#1167) Signed-off-by: mgorsk1 <gorskimariusz13@gmail.com> * fix: add optional list to atlas_search_extractor (#1180) Signed-off-by: dechoma <dominik.choma@gmail.com> * feat: introduce atlas serializable for dashboards (#1138) Signed-off-by: dechoma <dominik.choma@gmail.com> Co-authored-by: gorbachev <tpp+github@iki.fi> Co-authored-by: sewardgw <grant@stemma.ai> Co-authored-by: Verdan Mahmood <verdan.mahmood@gmail.com> Co-authored-by: Jakub Nowacki <j.s.nowacki@gmail.com> Co-authored-by: Fokko Driesprong <fokko@driesprong.frl> Co-authored-by: iamtodor <todor.ilya@gmail.com> Co-authored-by: James Davidheiser <jdavidheiser@users.noreply.github.com> Co-authored-by: mgorsk1 <gorskimariusz13@gmail.com> Co-authored-by: dechoma <dominik.choma@gmail.com> Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * feat: FE ML features additonal metadata endpoints (#1152) * bump up databuilder version to 4.4.1 (#1130) Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * made endpoint methods generic Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * feat: FE ML Feature get_feature_metadata (#1147) * functional API for feature details Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * lint Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * starting unit tests Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * changed naming Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * correct feat key Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * oopsie Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * mock data Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * removed stuff Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * expected metadata Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * tests should work now Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * oopies pt 2 Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * all unit tests Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * lint Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * format string Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * chore: remove a comment that conflicts with implementation (#1154) Signed-off-by: Tero Paananen <tpaananen@bloomberg.net> * feat: Common query models (#1155) * Added join and where models for how tables are joined / filtered with sql Signed-off-by: Grant Seward <grant@stemma.ai> * removed addl space Signed-off-by: Grant Seward <grant@stemma.ai> * version bump Signed-off-by: Grant Seward <grant@stemma.ai> * Added get-resource-generation_code Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * fixes, lint Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * more Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * prettier Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * feat: Configuration option to init custom routes (#1160) * configuration option to init custom routes Signed-off-by: verdan <verdan.mahmood@gmail.com> * Fixes isort Signed-off-by: verdan <verdan.mahmood@gmail.com> * :sigh: really fixes isort Signed-off-by: verdan <verdan.mahmood@gmail.com> * feat: Search service adding suport for AWS Elasticsearch (#1141) Signed-off-by: Jakub Nowacki <j.s.nowacki@gmail.com> * cleanup Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * unit tests Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * Fix installation link (#1159) The link was broken Signed-off-by: Fokko Driesprong <fokko@datafold.com> * fix: 1157 issude - metadata sql alchemy for iodc component (#1169) Signed-off-by: iamtodor <todor.ilya@gmail.com> * Helm service versions moved up to latest ones (#1165) Signed-off-by: Jakub Nowacki <j.s.nowacki@gmail.com> * Fix doc links in README.md (#1164) Just a quick driveby to fix a few doc links that still point to old locations. Signed-off-by: James Davidheiser <jamesdavidheiser@asana.com> * fix: aws_config (#1167) Signed-off-by: mgorsk1 <gorskimariusz13@gmail.com> * fix: add optional list to atlas_search_extractor (#1180) Signed-off-by: dechoma <dominik.choma@gmail.com> * feat: introduce atlas serializable for dashboards (#1138) Signed-off-by: dechoma <dominik.choma@gmail.com> * more unit tests Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * fixed tests Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * fixed lint long line issue Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * fixes and added unit tests Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * bumped version Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * implemented dmitry's feedback Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * fixed big oopsie Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * removed prints Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * lint Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> Co-authored-by: Junda Yang <youngyjd@gmail.com> Co-authored-by: gorbachev <tpp+github@iki.fi> Co-authored-by: sewardgw <grant@stemma.ai> Co-authored-by: Verdan Mahmood <verdan.mahmood@gmail.com> Co-authored-by: Jakub Nowacki <j.s.nowacki@gmail.com> Co-authored-by: Fokko Driesprong <fokko@driesprong.frl> Co-authored-by: iamtodor <todor.ilya@gmail.com> Co-authored-by: James Davidheiser <jdavidheiser@users.noreply.github.com> Co-authored-by: mgorsk1 <gorskimariusz13@gmail.com> Co-authored-by: dechoma <dominik.choma@gmail.com> Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * feat: Add databuilder models for Feature (#1190) * [feat] Add databuilder models for Feature Signed-off-by: Dmitriy Kunitskiy <dkunitskiy@lyft.com> * add feature model docs Signed-off-by: Dmitriy Kunitskiy <dkunitskiy@lyft.com> * fix dashboard owner test Signed-off-by: Dmitriy Kunitskiy <dkunitskiy@lyft.com> * lint failures Signed-off-by: Dmitriy Kunitskiy <dkunitskiy@lyft.com> * docstring improvements Signed-off-by: Dmitriy Kunitskiy <dkunitskiy@lyft.com> Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * feat: Add feature discovery route and page (#1185) * Added redux boilerplate for feature Signed-off-by: Daniel Won <dwon@lyft.com> * Add feature page basics Signed-off-by: Daniel Won <dwon@lyft.com> * - Added feature as a resource type - Code cleanup Signed-off-by: Daniel Won <dwon@lyft.com> * Add loading state for feature page - Removed 'prefer-promise-reject-errors' betterer rule Signed-off-by: Daniel Won <dwon@lyft.com> * Add tests to feature ducks Signed-off-by: Daniel Won <dwon@lyft.com> Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * upated queries for feture metadata Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * removed col code Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * new generation code changes instead fo query Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * test update Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * tests Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * tests 2 Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * testsss Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * sort imports Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * removed url Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * forgot to remove from common Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * should be done Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * forgot to add this Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * lint Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * changes Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * fingers crossed Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * fixed unit tests Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * fixed watermark issues and removed unnecessary logggers Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> Co-authored-by: Daniel <dwon@lyft.com> Co-authored-by: Junda Yang <youngyjd@gmail.com> Co-authored-by: gorbachev <tpp+github@iki.fi> Co-authored-by: sewardgw <grant@stemma.ai> Co-authored-by: Verdan Mahmood <verdan.mahmood@gmail.com> Co-authored-by: Jakub Nowacki <j.s.nowacki@gmail.com> Co-authored-by: Fokko Driesprong <fokko@driesprong.frl> Co-authored-by: iamtodor <todor.ilya@gmail.com> Co-authored-by: James Davidheiser <jdavidheiser@users.noreply.github.com> Co-authored-by: mgorsk1 <gorskimariusz13@gmail.com> Co-authored-by: dechoma <dominik.choma@gmail.com> Co-authored-by: Dmitriy Kunitskiy <dkunitskiy@lyft.com>
allisonsuarez
added a commit
that referenced
this pull request
Jun 17, 2021
* feat: Merge feature discovery work into protected branch (#1153) * bump up databuilder version to 4.4.1 (#1130) Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * feat: FE ML Feature get_feature_metadata (#1147) * functional API for feature details Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * lint Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * starting unit tests Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * changed naming Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * correct feat key Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * oopsie Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * mock data Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * removed stuff Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * expected metadata Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * tests should work now Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * oopies pt 2 Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * all unit tests Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * lint Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * format string Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * chore: remove a comment that conflicts with implementation (#1154) Signed-off-by: Tero Paananen <tpaananen@bloomberg.net> * feat: ML Feature Lineage (#1156) * funtional Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * unit tests Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * lint Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * 404 case and id Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> Co-authored-by: Junda Yang <youngyjd@gmail.com> Co-authored-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> Co-authored-by: Allison Suarez Miranda <22477579+allisonsuarez@users.noreply.github.com> Co-authored-by: gorbachev <tpp+github@iki.fi> * chore: get latest code from main (#1181) * chore: remove a comment that conflicts with implementation (#1154) Signed-off-by: Tero Paananen <tpaananen@bloomberg.net> * feat: Common query models (#1155) * Added join and where models for how tables are joined / filtered with sql Signed-off-by: Grant Seward <grant@stemma.ai> * removed addl space Signed-off-by: Grant Seward <grant@stemma.ai> * version bump Signed-off-by: Grant Seward <grant@stemma.ai> * feat: Configuration option to init custom routes (#1160) * configuration option to init custom routes Signed-off-by: verdan <verdan.mahmood@gmail.com> * Fixes isort Signed-off-by: verdan <verdan.mahmood@gmail.com> * :sigh: really fixes isort Signed-off-by: verdan <verdan.mahmood@gmail.com> * feat: Search service adding suport for AWS Elasticsearch (#1141) Signed-off-by: Jakub Nowacki <j.s.nowacki@gmail.com> * Fix installation link (#1159) The link was broken Signed-off-by: Fokko Driesprong <fokko@datafold.com> * fix: 1157 issude - metadata sql alchemy for iodc component (#1169) Signed-off-by: iamtodor <todor.ilya@gmail.com> * Helm service versions moved up to latest ones (#1165) Signed-off-by: Jakub Nowacki <j.s.nowacki@gmail.com> * Fix doc links in README.md (#1164) Just a quick driveby to fix a few doc links that still point to old locations. Signed-off-by: James Davidheiser <jamesdavidheiser@asana.com> * fix: aws_config (#1167) Signed-off-by: mgorsk1 <gorskimariusz13@gmail.com> * fix: add optional list to atlas_search_extractor (#1180) Signed-off-by: dechoma <dominik.choma@gmail.com> * feat: introduce atlas serializable for dashboards (#1138) Signed-off-by: dechoma <dominik.choma@gmail.com> Co-authored-by: gorbachev <tpp+github@iki.fi> Co-authored-by: sewardgw <grant@stemma.ai> Co-authored-by: Verdan Mahmood <verdan.mahmood@gmail.com> Co-authored-by: Jakub Nowacki <j.s.nowacki@gmail.com> Co-authored-by: Fokko Driesprong <fokko@driesprong.frl> Co-authored-by: iamtodor <todor.ilya@gmail.com> Co-authored-by: James Davidheiser <jdavidheiser@users.noreply.github.com> Co-authored-by: mgorsk1 <gorskimariusz13@gmail.com> Co-authored-by: dechoma <dominik.choma@gmail.com> * feat: FE ML features additonal metadata endpoints (#1152) * bump up databuilder version to 4.4.1 (#1130) Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * made endpoint methods generic Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * feat: FE ML Feature get_feature_metadata (#1147) * functional API for feature details Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * lint Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * starting unit tests Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * changed naming Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * correct feat key Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * oopsie Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * mock data Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * removed stuff Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * expected metadata Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * tests should work now Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * oopies pt 2 Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * all unit tests Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * lint Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * format string Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * chore: remove a comment that conflicts with implementation (#1154) Signed-off-by: Tero Paananen <tpaananen@bloomberg.net> * feat: Common query models (#1155) * Added join and where models for how tables are joined / filtered with sql Signed-off-by: Grant Seward <grant@stemma.ai> * removed addl space Signed-off-by: Grant Seward <grant@stemma.ai> * version bump Signed-off-by: Grant Seward <grant@stemma.ai> * Added get-resource-generation_code Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * fixes, lint Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * more Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * prettier Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * feat: Configuration option to init custom routes (#1160) * configuration option to init custom routes Signed-off-by: verdan <verdan.mahmood@gmail.com> * Fixes isort Signed-off-by: verdan <verdan.mahmood@gmail.com> * :sigh: really fixes isort Signed-off-by: verdan <verdan.mahmood@gmail.com> * feat: Search service adding suport for AWS Elasticsearch (#1141) Signed-off-by: Jakub Nowacki <j.s.nowacki@gmail.com> * cleanup Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * unit tests Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * Fix installation link (#1159) The link was broken Signed-off-by: Fokko Driesprong <fokko@datafold.com> * fix: 1157 issude - metadata sql alchemy for iodc component (#1169) Signed-off-by: iamtodor <todor.ilya@gmail.com> * Helm service versions moved up to latest ones (#1165) Signed-off-by: Jakub Nowacki <j.s.nowacki@gmail.com> * Fix doc links in README.md (#1164) Just a quick driveby to fix a few doc links that still point to old locations. Signed-off-by: James Davidheiser <jamesdavidheiser@asana.com> * fix: aws_config (#1167) Signed-off-by: mgorsk1 <gorskimariusz13@gmail.com> * fix: add optional list to atlas_search_extractor (#1180) Signed-off-by: dechoma <dominik.choma@gmail.com> * feat: introduce atlas serializable for dashboards (#1138) Signed-off-by: dechoma <dominik.choma@gmail.com> * more unit tests Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * fixed tests Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * fixed lint long line issue Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * fixes and added unit tests Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * bumped version Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * implemented dmitry's feedback Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * fixed big oopsie Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * removed prints Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * lint Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> Co-authored-by: Junda Yang <youngyjd@gmail.com> Co-authored-by: gorbachev <tpp+github@iki.fi> Co-authored-by: sewardgw <grant@stemma.ai> Co-authored-by: Verdan Mahmood <verdan.mahmood@gmail.com> Co-authored-by: Jakub Nowacki <j.s.nowacki@gmail.com> Co-authored-by: Fokko Driesprong <fokko@driesprong.frl> Co-authored-by: iamtodor <todor.ilya@gmail.com> Co-authored-by: James Davidheiser <jdavidheiser@users.noreply.github.com> Co-authored-by: mgorsk1 <gorskimariusz13@gmail.com> Co-authored-by: dechoma <dominik.choma@gmail.com> * feat: Add databuilder models for Feature (#1190) * [feat] Add databuilder models for Feature Signed-off-by: Dmitriy Kunitskiy <dkunitskiy@lyft.com> * add feature model docs Signed-off-by: Dmitriy Kunitskiy <dkunitskiy@lyft.com> * fix dashboard owner test Signed-off-by: Dmitriy Kunitskiy <dkunitskiy@lyft.com> * lint failures Signed-off-by: Dmitriy Kunitskiy <dkunitskiy@lyft.com> * docstring improvements Signed-off-by: Dmitriy Kunitskiy <dkunitskiy@lyft.com> * feat: Add feature discovery route and page (#1185) * Added redux boilerplate for feature Signed-off-by: Daniel Won <dwon@lyft.com> * Add feature page basics Signed-off-by: Daniel Won <dwon@lyft.com> * - Added feature as a resource type - Code cleanup Signed-off-by: Daniel Won <dwon@lyft.com> * Add loading state for feature page - Removed 'prefer-promise-reject-errors' betterer rule Signed-off-by: Daniel Won <dwon@lyft.com> * Add tests to feature ducks Signed-off-by: Daniel Won <dwon@lyft.com> * work for feature search Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * update interface Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * corrected help text for feature filters Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * functional resource selector, filters, etc for ML features, still need API work which will be in separate PR Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * badge list option Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * revert this change, will put it in separate PR Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * betterer not working to update Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * better Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * fixed unit test Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * lint, its too late for this Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * removed debug logs Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * Adds tests to some components Signed-off-by: Marcos Iglesias <miglesiasvalle@lyft.com> * Brings back eslint ignore line Signed-off-by: Marcos Iglesias <miglesiasvalle@lyft.com> Co-authored-by: Daniel <dwon@lyft.com> Co-authored-by: Junda Yang <youngyjd@gmail.com> Co-authored-by: gorbachev <tpp+github@iki.fi> Co-authored-by: sewardgw <grant@stemma.ai> Co-authored-by: Verdan Mahmood <verdan.mahmood@gmail.com> Co-authored-by: Jakub Nowacki <j.s.nowacki@gmail.com> Co-authored-by: Fokko Driesprong <fokko@driesprong.frl> Co-authored-by: iamtodor <todor.ilya@gmail.com> Co-authored-by: James Davidheiser <jdavidheiser@users.noreply.github.com> Co-authored-by: mgorsk1 <gorskimariusz13@gmail.com> Co-authored-by: dechoma <dominik.choma@gmail.com> Co-authored-by: Dmitriy Kunitskiy <dkunitskiy@lyft.com> Co-authored-by: Marcos Iglesias <miglesiasvalle@lyft.com>
amommendes
pushed a commit
to amommendes/amundsen
that referenced
this pull request
Jul 22, 2021
* feat: Merge feature discovery work into protected branch (amundsen-io#1153) * bump up databuilder version to 4.4.1 (amundsen-io#1130) Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * feat: FE ML Feature get_feature_metadata (amundsen-io#1147) * functional API for feature details Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * lint Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * starting unit tests Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * changed naming Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * correct feat key Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * oopsie Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * mock data Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * removed stuff Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * expected metadata Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * tests should work now Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * oopies pt 2 Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * all unit tests Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * lint Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * format string Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * chore: remove a comment that conflicts with implementation (amundsen-io#1154) Signed-off-by: Tero Paananen <tpaananen@bloomberg.net> * feat: ML Feature Lineage (amundsen-io#1156) * funtional Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * unit tests Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * lint Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * 404 case and id Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> Co-authored-by: Junda Yang <youngyjd@gmail.com> Co-authored-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> Co-authored-by: Allison Suarez Miranda <22477579+allisonsuarez@users.noreply.github.com> Co-authored-by: gorbachev <tpp+github@iki.fi> * chore: get latest code from main (amundsen-io#1181) * chore: remove a comment that conflicts with implementation (amundsen-io#1154) Signed-off-by: Tero Paananen <tpaananen@bloomberg.net> * feat: Common query models (amundsen-io#1155) * Added join and where models for how tables are joined / filtered with sql Signed-off-by: Grant Seward <grant@stemma.ai> * removed addl space Signed-off-by: Grant Seward <grant@stemma.ai> * version bump Signed-off-by: Grant Seward <grant@stemma.ai> * feat: Configuration option to init custom routes (amundsen-io#1160) * configuration option to init custom routes Signed-off-by: verdan <verdan.mahmood@gmail.com> * Fixes isort Signed-off-by: verdan <verdan.mahmood@gmail.com> * :sigh: really fixes isort Signed-off-by: verdan <verdan.mahmood@gmail.com> * feat: Search service adding suport for AWS Elasticsearch (amundsen-io#1141) Signed-off-by: Jakub Nowacki <j.s.nowacki@gmail.com> * Fix installation link (amundsen-io#1159) The link was broken Signed-off-by: Fokko Driesprong <fokko@datafold.com> * fix: 1157 issude - metadata sql alchemy for iodc component (amundsen-io#1169) Signed-off-by: iamtodor <todor.ilya@gmail.com> * Helm service versions moved up to latest ones (amundsen-io#1165) Signed-off-by: Jakub Nowacki <j.s.nowacki@gmail.com> * Fix doc links in README.md (amundsen-io#1164) Just a quick driveby to fix a few doc links that still point to old locations. Signed-off-by: James Davidheiser <jamesdavidheiser@asana.com> * fix: aws_config (amundsen-io#1167) Signed-off-by: mgorsk1 <gorskimariusz13@gmail.com> * fix: add optional list to atlas_search_extractor (amundsen-io#1180) Signed-off-by: dechoma <dominik.choma@gmail.com> * feat: introduce atlas serializable for dashboards (amundsen-io#1138) Signed-off-by: dechoma <dominik.choma@gmail.com> Co-authored-by: gorbachev <tpp+github@iki.fi> Co-authored-by: sewardgw <grant@stemma.ai> Co-authored-by: Verdan Mahmood <verdan.mahmood@gmail.com> Co-authored-by: Jakub Nowacki <j.s.nowacki@gmail.com> Co-authored-by: Fokko Driesprong <fokko@driesprong.frl> Co-authored-by: iamtodor <todor.ilya@gmail.com> Co-authored-by: James Davidheiser <jdavidheiser@users.noreply.github.com> Co-authored-by: mgorsk1 <gorskimariusz13@gmail.com> Co-authored-by: dechoma <dominik.choma@gmail.com> * feat: FE ML features additonal metadata endpoints (amundsen-io#1152) * bump up databuilder version to 4.4.1 (amundsen-io#1130) Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * made endpoint methods generic Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * feat: FE ML Feature get_feature_metadata (amundsen-io#1147) * functional API for feature details Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * lint Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * starting unit tests Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * changed naming Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * correct feat key Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * oopsie Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * mock data Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * removed stuff Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * expected metadata Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * tests should work now Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * oopies pt 2 Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * all unit tests Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * lint Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * format string Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * chore: remove a comment that conflicts with implementation (amundsen-io#1154) Signed-off-by: Tero Paananen <tpaananen@bloomberg.net> * feat: Common query models (amundsen-io#1155) * Added join and where models for how tables are joined / filtered with sql Signed-off-by: Grant Seward <grant@stemma.ai> * removed addl space Signed-off-by: Grant Seward <grant@stemma.ai> * version bump Signed-off-by: Grant Seward <grant@stemma.ai> * Added get-resource-generation_code Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * fixes, lint Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * more Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * prettier Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * feat: Configuration option to init custom routes (amundsen-io#1160) * configuration option to init custom routes Signed-off-by: verdan <verdan.mahmood@gmail.com> * Fixes isort Signed-off-by: verdan <verdan.mahmood@gmail.com> * :sigh: really fixes isort Signed-off-by: verdan <verdan.mahmood@gmail.com> * feat: Search service adding suport for AWS Elasticsearch (amundsen-io#1141) Signed-off-by: Jakub Nowacki <j.s.nowacki@gmail.com> * cleanup Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * unit tests Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * Fix installation link (amundsen-io#1159) The link was broken Signed-off-by: Fokko Driesprong <fokko@datafold.com> * fix: 1157 issude - metadata sql alchemy for iodc component (amundsen-io#1169) Signed-off-by: iamtodor <todor.ilya@gmail.com> * Helm service versions moved up to latest ones (amundsen-io#1165) Signed-off-by: Jakub Nowacki <j.s.nowacki@gmail.com> * Fix doc links in README.md (amundsen-io#1164) Just a quick driveby to fix a few doc links that still point to old locations. Signed-off-by: James Davidheiser <jamesdavidheiser@asana.com> * fix: aws_config (amundsen-io#1167) Signed-off-by: mgorsk1 <gorskimariusz13@gmail.com> * fix: add optional list to atlas_search_extractor (amundsen-io#1180) Signed-off-by: dechoma <dominik.choma@gmail.com> * feat: introduce atlas serializable for dashboards (amundsen-io#1138) Signed-off-by: dechoma <dominik.choma@gmail.com> * more unit tests Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * fixed tests Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * fixed lint long line issue Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * fixes and added unit tests Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * bumped version Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * implemented dmitry's feedback Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * fixed big oopsie Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * removed prints Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * lint Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> Co-authored-by: Junda Yang <youngyjd@gmail.com> Co-authored-by: gorbachev <tpp+github@iki.fi> Co-authored-by: sewardgw <grant@stemma.ai> Co-authored-by: Verdan Mahmood <verdan.mahmood@gmail.com> Co-authored-by: Jakub Nowacki <j.s.nowacki@gmail.com> Co-authored-by: Fokko Driesprong <fokko@driesprong.frl> Co-authored-by: iamtodor <todor.ilya@gmail.com> Co-authored-by: James Davidheiser <jdavidheiser@users.noreply.github.com> Co-authored-by: mgorsk1 <gorskimariusz13@gmail.com> Co-authored-by: dechoma <dominik.choma@gmail.com> * feat: Add databuilder models for Feature (amundsen-io#1190) * [feat] Add databuilder models for Feature Signed-off-by: Dmitriy Kunitskiy <dkunitskiy@lyft.com> * add feature model docs Signed-off-by: Dmitriy Kunitskiy <dkunitskiy@lyft.com> * fix dashboard owner test Signed-off-by: Dmitriy Kunitskiy <dkunitskiy@lyft.com> * lint failures Signed-off-by: Dmitriy Kunitskiy <dkunitskiy@lyft.com> * docstring improvements Signed-off-by: Dmitriy Kunitskiy <dkunitskiy@lyft.com> * feat: Add feature discovery route and page (amundsen-io#1185) * Added redux boilerplate for feature Signed-off-by: Daniel Won <dwon@lyft.com> * Add feature page basics Signed-off-by: Daniel Won <dwon@lyft.com> * - Added feature as a resource type - Code cleanup Signed-off-by: Daniel Won <dwon@lyft.com> * Add loading state for feature page - Removed 'prefer-promise-reject-errors' betterer rule Signed-off-by: Daniel Won <dwon@lyft.com> * Add tests to feature ducks Signed-off-by: Daniel Won <dwon@lyft.com> * work for feature search Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * update interface Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * corrected help text for feature filters Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * functional resource selector, filters, etc for ML features, still need API work which will be in separate PR Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * badge list option Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * revert this change, will put it in separate PR Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * betterer not working to update Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * better Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * fixed unit test Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * lint, its too late for this Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * removed debug logs Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * Adds tests to some components Signed-off-by: Marcos Iglesias <miglesiasvalle@lyft.com> * Brings back eslint ignore line Signed-off-by: Marcos Iglesias <miglesiasvalle@lyft.com> Co-authored-by: Daniel <dwon@lyft.com> Co-authored-by: Junda Yang <youngyjd@gmail.com> Co-authored-by: gorbachev <tpp+github@iki.fi> Co-authored-by: sewardgw <grant@stemma.ai> Co-authored-by: Verdan Mahmood <verdan.mahmood@gmail.com> Co-authored-by: Jakub Nowacki <j.s.nowacki@gmail.com> Co-authored-by: Fokko Driesprong <fokko@driesprong.frl> Co-authored-by: iamtodor <todor.ilya@gmail.com> Co-authored-by: James Davidheiser <jdavidheiser@users.noreply.github.com> Co-authored-by: mgorsk1 <gorskimariusz13@gmail.com> Co-authored-by: dechoma <dominik.choma@gmail.com> Co-authored-by: Dmitriy Kunitskiy <dkunitskiy@lyft.com> Co-authored-by: Marcos Iglesias <miglesiasvalle@lyft.com> Signed-off-by: Amom <amommendes@hotmail.com>
zacr
pushed a commit
to SaltIO/amundsen
that referenced
this pull request
May 13, 2022
* feat: Merge feature discovery work into protected branch (amundsen-io#1153) * bump up databuilder version to 4.4.1 (amundsen-io#1130) Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * feat: FE ML Feature get_feature_metadata (amundsen-io#1147) * functional API for feature details Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * lint Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * starting unit tests Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * changed naming Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * correct feat key Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * oopsie Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * mock data Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * removed stuff Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * expected metadata Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * tests should work now Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * oopies pt 2 Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * all unit tests Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * lint Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * format string Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * chore: remove a comment that conflicts with implementation (amundsen-io#1154) Signed-off-by: Tero Paananen <tpaananen@bloomberg.net> * feat: ML Feature Lineage (amundsen-io#1156) * funtional Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * unit tests Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * lint Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * 404 case and id Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> Co-authored-by: Junda Yang <youngyjd@gmail.com> Co-authored-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> Co-authored-by: Allison Suarez Miranda <22477579+allisonsuarez@users.noreply.github.com> Co-authored-by: gorbachev <tpp+github@iki.fi> * chore: get latest code from main (amundsen-io#1181) * chore: remove a comment that conflicts with implementation (amundsen-io#1154) Signed-off-by: Tero Paananen <tpaananen@bloomberg.net> * feat: Common query models (amundsen-io#1155) * Added join and where models for how tables are joined / filtered with sql Signed-off-by: Grant Seward <grant@stemma.ai> * removed addl space Signed-off-by: Grant Seward <grant@stemma.ai> * version bump Signed-off-by: Grant Seward <grant@stemma.ai> * feat: Configuration option to init custom routes (amundsen-io#1160) * configuration option to init custom routes Signed-off-by: verdan <verdan.mahmood@gmail.com> * Fixes isort Signed-off-by: verdan <verdan.mahmood@gmail.com> * :sigh: really fixes isort Signed-off-by: verdan <verdan.mahmood@gmail.com> * feat: Search service adding suport for AWS Elasticsearch (amundsen-io#1141) Signed-off-by: Jakub Nowacki <j.s.nowacki@gmail.com> * Fix installation link (amundsen-io#1159) The link was broken Signed-off-by: Fokko Driesprong <fokko@datafold.com> * fix: 1157 issude - metadata sql alchemy for iodc component (amundsen-io#1169) Signed-off-by: iamtodor <todor.ilya@gmail.com> * Helm service versions moved up to latest ones (amundsen-io#1165) Signed-off-by: Jakub Nowacki <j.s.nowacki@gmail.com> * Fix doc links in README.md (amundsen-io#1164) Just a quick driveby to fix a few doc links that still point to old locations. Signed-off-by: James Davidheiser <jamesdavidheiser@asana.com> * fix: aws_config (amundsen-io#1167) Signed-off-by: mgorsk1 <gorskimariusz13@gmail.com> * fix: add optional list to atlas_search_extractor (amundsen-io#1180) Signed-off-by: dechoma <dominik.choma@gmail.com> * feat: introduce atlas serializable for dashboards (amundsen-io#1138) Signed-off-by: dechoma <dominik.choma@gmail.com> Co-authored-by: gorbachev <tpp+github@iki.fi> Co-authored-by: sewardgw <grant@stemma.ai> Co-authored-by: Verdan Mahmood <verdan.mahmood@gmail.com> Co-authored-by: Jakub Nowacki <j.s.nowacki@gmail.com> Co-authored-by: Fokko Driesprong <fokko@driesprong.frl> Co-authored-by: iamtodor <todor.ilya@gmail.com> Co-authored-by: James Davidheiser <jdavidheiser@users.noreply.github.com> Co-authored-by: mgorsk1 <gorskimariusz13@gmail.com> Co-authored-by: dechoma <dominik.choma@gmail.com> * feat: FE ML features additonal metadata endpoints (amundsen-io#1152) * bump up databuilder version to 4.4.1 (amundsen-io#1130) Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * made endpoint methods generic Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * feat: FE ML Feature get_feature_metadata (amundsen-io#1147) * functional API for feature details Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * lint Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * starting unit tests Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * changed naming Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * correct feat key Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * oopsie Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * mock data Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * removed stuff Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * expected metadata Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * tests should work now Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * oopies pt 2 Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * all unit tests Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * lint Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * format string Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * chore: remove a comment that conflicts with implementation (amundsen-io#1154) Signed-off-by: Tero Paananen <tpaananen@bloomberg.net> * feat: Common query models (amundsen-io#1155) * Added join and where models for how tables are joined / filtered with sql Signed-off-by: Grant Seward <grant@stemma.ai> * removed addl space Signed-off-by: Grant Seward <grant@stemma.ai> * version bump Signed-off-by: Grant Seward <grant@stemma.ai> * Added get-resource-generation_code Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * fixes, lint Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * more Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * prettier Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * feat: Configuration option to init custom routes (amundsen-io#1160) * configuration option to init custom routes Signed-off-by: verdan <verdan.mahmood@gmail.com> * Fixes isort Signed-off-by: verdan <verdan.mahmood@gmail.com> * :sigh: really fixes isort Signed-off-by: verdan <verdan.mahmood@gmail.com> * feat: Search service adding suport for AWS Elasticsearch (amundsen-io#1141) Signed-off-by: Jakub Nowacki <j.s.nowacki@gmail.com> * cleanup Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * unit tests Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * Fix installation link (amundsen-io#1159) The link was broken Signed-off-by: Fokko Driesprong <fokko@datafold.com> * fix: 1157 issude - metadata sql alchemy for iodc component (amundsen-io#1169) Signed-off-by: iamtodor <todor.ilya@gmail.com> * Helm service versions moved up to latest ones (amundsen-io#1165) Signed-off-by: Jakub Nowacki <j.s.nowacki@gmail.com> * Fix doc links in README.md (amundsen-io#1164) Just a quick driveby to fix a few doc links that still point to old locations. Signed-off-by: James Davidheiser <jamesdavidheiser@asana.com> * fix: aws_config (amundsen-io#1167) Signed-off-by: mgorsk1 <gorskimariusz13@gmail.com> * fix: add optional list to atlas_search_extractor (amundsen-io#1180) Signed-off-by: dechoma <dominik.choma@gmail.com> * feat: introduce atlas serializable for dashboards (amundsen-io#1138) Signed-off-by: dechoma <dominik.choma@gmail.com> * more unit tests Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * fixed tests Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * fixed lint long line issue Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * fixes and added unit tests Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * bumped version Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * implemented dmitry's feedback Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * fixed big oopsie Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * removed prints Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * lint Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> Co-authored-by: Junda Yang <youngyjd@gmail.com> Co-authored-by: gorbachev <tpp+github@iki.fi> Co-authored-by: sewardgw <grant@stemma.ai> Co-authored-by: Verdan Mahmood <verdan.mahmood@gmail.com> Co-authored-by: Jakub Nowacki <j.s.nowacki@gmail.com> Co-authored-by: Fokko Driesprong <fokko@driesprong.frl> Co-authored-by: iamtodor <todor.ilya@gmail.com> Co-authored-by: James Davidheiser <jdavidheiser@users.noreply.github.com> Co-authored-by: mgorsk1 <gorskimariusz13@gmail.com> Co-authored-by: dechoma <dominik.choma@gmail.com> * feat: Add databuilder models for Feature (amundsen-io#1190) * [feat] Add databuilder models for Feature Signed-off-by: Dmitriy Kunitskiy <dkunitskiy@lyft.com> * add feature model docs Signed-off-by: Dmitriy Kunitskiy <dkunitskiy@lyft.com> * fix dashboard owner test Signed-off-by: Dmitriy Kunitskiy <dkunitskiy@lyft.com> * lint failures Signed-off-by: Dmitriy Kunitskiy <dkunitskiy@lyft.com> * docstring improvements Signed-off-by: Dmitriy Kunitskiy <dkunitskiy@lyft.com> * feat: Add feature discovery route and page (amundsen-io#1185) * Added redux boilerplate for feature Signed-off-by: Daniel Won <dwon@lyft.com> * Add feature page basics Signed-off-by: Daniel Won <dwon@lyft.com> * - Added feature as a resource type - Code cleanup Signed-off-by: Daniel Won <dwon@lyft.com> * Add loading state for feature page - Removed 'prefer-promise-reject-errors' betterer rule Signed-off-by: Daniel Won <dwon@lyft.com> * Add tests to feature ducks Signed-off-by: Daniel Won <dwon@lyft.com> * work for feature search Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * update interface Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * corrected help text for feature filters Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * functional resource selector, filters, etc for ML features, still need API work which will be in separate PR Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * badge list option Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * revert this change, will put it in separate PR Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * betterer not working to update Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * better Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * fixed unit test Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * lint, its too late for this Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * removed debug logs Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * Adds tests to some components Signed-off-by: Marcos Iglesias <miglesiasvalle@lyft.com> * Brings back eslint ignore line Signed-off-by: Marcos Iglesias <miglesiasvalle@lyft.com> Co-authored-by: Daniel <dwon@lyft.com> Co-authored-by: Junda Yang <youngyjd@gmail.com> Co-authored-by: gorbachev <tpp+github@iki.fi> Co-authored-by: sewardgw <grant@stemma.ai> Co-authored-by: Verdan Mahmood <verdan.mahmood@gmail.com> Co-authored-by: Jakub Nowacki <j.s.nowacki@gmail.com> Co-authored-by: Fokko Driesprong <fokko@driesprong.frl> Co-authored-by: iamtodor <todor.ilya@gmail.com> Co-authored-by: James Davidheiser <jdavidheiser@users.noreply.github.com> Co-authored-by: mgorsk1 <gorskimariusz13@gmail.com> Co-authored-by: dechoma <dominik.choma@gmail.com> Co-authored-by: Dmitriy Kunitskiy <dkunitskiy@lyft.com> Co-authored-by: Marcos Iglesias <miglesiasvalle@lyft.com>
hansadriaans
pushed a commit
to DataChefHQ/amundsen
that referenced
this pull request
Jun 30, 2022
* feat: Merge feature discovery work into protected branch (amundsen-io#1153) * bump up databuilder version to 4.4.1 (amundsen-io#1130) Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * feat: FE ML Feature get_feature_metadata (amundsen-io#1147) * functional API for feature details Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * lint Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * starting unit tests Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * changed naming Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * correct feat key Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * oopsie Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * mock data Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * removed stuff Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * expected metadata Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * tests should work now Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * oopies pt 2 Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * all unit tests Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * lint Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * format string Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * chore: remove a comment that conflicts with implementation (amundsen-io#1154) Signed-off-by: Tero Paananen <tpaananen@bloomberg.net> * feat: ML Feature Lineage (amundsen-io#1156) * funtional Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * unit tests Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * lint Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * 404 case and id Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> Co-authored-by: Junda Yang <youngyjd@gmail.com> Co-authored-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> Co-authored-by: Allison Suarez Miranda <22477579+allisonsuarez@users.noreply.github.com> Co-authored-by: gorbachev <tpp+github@iki.fi> * chore: get latest code from main (amundsen-io#1181) * chore: remove a comment that conflicts with implementation (amundsen-io#1154) Signed-off-by: Tero Paananen <tpaananen@bloomberg.net> * feat: Common query models (amundsen-io#1155) * Added join and where models for how tables are joined / filtered with sql Signed-off-by: Grant Seward <grant@stemma.ai> * removed addl space Signed-off-by: Grant Seward <grant@stemma.ai> * version bump Signed-off-by: Grant Seward <grant@stemma.ai> * feat: Configuration option to init custom routes (amundsen-io#1160) * configuration option to init custom routes Signed-off-by: verdan <verdan.mahmood@gmail.com> * Fixes isort Signed-off-by: verdan <verdan.mahmood@gmail.com> * :sigh: really fixes isort Signed-off-by: verdan <verdan.mahmood@gmail.com> * feat: Search service adding suport for AWS Elasticsearch (amundsen-io#1141) Signed-off-by: Jakub Nowacki <j.s.nowacki@gmail.com> * Fix installation link (amundsen-io#1159) The link was broken Signed-off-by: Fokko Driesprong <fokko@datafold.com> * fix: 1157 issude - metadata sql alchemy for iodc component (amundsen-io#1169) Signed-off-by: iamtodor <todor.ilya@gmail.com> * Helm service versions moved up to latest ones (amundsen-io#1165) Signed-off-by: Jakub Nowacki <j.s.nowacki@gmail.com> * Fix doc links in README.md (amundsen-io#1164) Just a quick driveby to fix a few doc links that still point to old locations. Signed-off-by: James Davidheiser <jamesdavidheiser@asana.com> * fix: aws_config (amundsen-io#1167) Signed-off-by: mgorsk1 <gorskimariusz13@gmail.com> * fix: add optional list to atlas_search_extractor (amundsen-io#1180) Signed-off-by: dechoma <dominik.choma@gmail.com> * feat: introduce atlas serializable for dashboards (amundsen-io#1138) Signed-off-by: dechoma <dominik.choma@gmail.com> Co-authored-by: gorbachev <tpp+github@iki.fi> Co-authored-by: sewardgw <grant@stemma.ai> Co-authored-by: Verdan Mahmood <verdan.mahmood@gmail.com> Co-authored-by: Jakub Nowacki <j.s.nowacki@gmail.com> Co-authored-by: Fokko Driesprong <fokko@driesprong.frl> Co-authored-by: iamtodor <todor.ilya@gmail.com> Co-authored-by: James Davidheiser <jdavidheiser@users.noreply.github.com> Co-authored-by: mgorsk1 <gorskimariusz13@gmail.com> Co-authored-by: dechoma <dominik.choma@gmail.com> * feat: FE ML features additonal metadata endpoints (amundsen-io#1152) * bump up databuilder version to 4.4.1 (amundsen-io#1130) Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * made endpoint methods generic Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * feat: FE ML Feature get_feature_metadata (amundsen-io#1147) * functional API for feature details Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * lint Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * starting unit tests Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * changed naming Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * correct feat key Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * oopsie Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * mock data Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * removed stuff Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * expected metadata Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * tests should work now Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * oopies pt 2 Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * all unit tests Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * lint Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * format string Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * chore: remove a comment that conflicts with implementation (amundsen-io#1154) Signed-off-by: Tero Paananen <tpaananen@bloomberg.net> * feat: Common query models (amundsen-io#1155) * Added join and where models for how tables are joined / filtered with sql Signed-off-by: Grant Seward <grant@stemma.ai> * removed addl space Signed-off-by: Grant Seward <grant@stemma.ai> * version bump Signed-off-by: Grant Seward <grant@stemma.ai> * Added get-resource-generation_code Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * fixes, lint Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * more Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * prettier Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * feat: Configuration option to init custom routes (amundsen-io#1160) * configuration option to init custom routes Signed-off-by: verdan <verdan.mahmood@gmail.com> * Fixes isort Signed-off-by: verdan <verdan.mahmood@gmail.com> * :sigh: really fixes isort Signed-off-by: verdan <verdan.mahmood@gmail.com> * feat: Search service adding suport for AWS Elasticsearch (amundsen-io#1141) Signed-off-by: Jakub Nowacki <j.s.nowacki@gmail.com> * cleanup Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * unit tests Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * Fix installation link (amundsen-io#1159) The link was broken Signed-off-by: Fokko Driesprong <fokko@datafold.com> * fix: 1157 issude - metadata sql alchemy for iodc component (amundsen-io#1169) Signed-off-by: iamtodor <todor.ilya@gmail.com> * Helm service versions moved up to latest ones (amundsen-io#1165) Signed-off-by: Jakub Nowacki <j.s.nowacki@gmail.com> * Fix doc links in README.md (amundsen-io#1164) Just a quick driveby to fix a few doc links that still point to old locations. Signed-off-by: James Davidheiser <jamesdavidheiser@asana.com> * fix: aws_config (amundsen-io#1167) Signed-off-by: mgorsk1 <gorskimariusz13@gmail.com> * fix: add optional list to atlas_search_extractor (amundsen-io#1180) Signed-off-by: dechoma <dominik.choma@gmail.com> * feat: introduce atlas serializable for dashboards (amundsen-io#1138) Signed-off-by: dechoma <dominik.choma@gmail.com> * more unit tests Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * fixed tests Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * fixed lint long line issue Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * fixes and added unit tests Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * bumped version Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * implemented dmitry's feedback Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * fixed big oopsie Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * removed prints Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * lint Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> Co-authored-by: Junda Yang <youngyjd@gmail.com> Co-authored-by: gorbachev <tpp+github@iki.fi> Co-authored-by: sewardgw <grant@stemma.ai> Co-authored-by: Verdan Mahmood <verdan.mahmood@gmail.com> Co-authored-by: Jakub Nowacki <j.s.nowacki@gmail.com> Co-authored-by: Fokko Driesprong <fokko@driesprong.frl> Co-authored-by: iamtodor <todor.ilya@gmail.com> Co-authored-by: James Davidheiser <jdavidheiser@users.noreply.github.com> Co-authored-by: mgorsk1 <gorskimariusz13@gmail.com> Co-authored-by: dechoma <dominik.choma@gmail.com> * feat: Add databuilder models for Feature (amundsen-io#1190) * [feat] Add databuilder models for Feature Signed-off-by: Dmitriy Kunitskiy <dkunitskiy@lyft.com> * add feature model docs Signed-off-by: Dmitriy Kunitskiy <dkunitskiy@lyft.com> * fix dashboard owner test Signed-off-by: Dmitriy Kunitskiy <dkunitskiy@lyft.com> * lint failures Signed-off-by: Dmitriy Kunitskiy <dkunitskiy@lyft.com> * docstring improvements Signed-off-by: Dmitriy Kunitskiy <dkunitskiy@lyft.com> * feat: Add feature discovery route and page (amundsen-io#1185) * Added redux boilerplate for feature Signed-off-by: Daniel Won <dwon@lyft.com> * Add feature page basics Signed-off-by: Daniel Won <dwon@lyft.com> * - Added feature as a resource type - Code cleanup Signed-off-by: Daniel Won <dwon@lyft.com> * Add loading state for feature page - Removed 'prefer-promise-reject-errors' betterer rule Signed-off-by: Daniel Won <dwon@lyft.com> * Add tests to feature ducks Signed-off-by: Daniel Won <dwon@lyft.com> * work for feature search Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * update interface Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * corrected help text for feature filters Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * functional resource selector, filters, etc for ML features, still need API work which will be in separate PR Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * badge list option Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * revert this change, will put it in separate PR Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * betterer not working to update Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * better Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * fixed unit test Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * lint, its too late for this Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * removed debug logs Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * Adds tests to some components Signed-off-by: Marcos Iglesias <miglesiasvalle@lyft.com> * Brings back eslint ignore line Signed-off-by: Marcos Iglesias <miglesiasvalle@lyft.com> Co-authored-by: Daniel <dwon@lyft.com> Co-authored-by: Junda Yang <youngyjd@gmail.com> Co-authored-by: gorbachev <tpp+github@iki.fi> Co-authored-by: sewardgw <grant@stemma.ai> Co-authored-by: Verdan Mahmood <verdan.mahmood@gmail.com> Co-authored-by: Jakub Nowacki <j.s.nowacki@gmail.com> Co-authored-by: Fokko Driesprong <fokko@driesprong.frl> Co-authored-by: iamtodor <todor.ilya@gmail.com> Co-authored-by: James Davidheiser <jdavidheiser@users.noreply.github.com> Co-authored-by: mgorsk1 <gorskimariusz13@gmail.com> Co-authored-by: dechoma <dominik.choma@gmail.com> Co-authored-by: Dmitriy Kunitskiy <dkunitskiy@lyft.com> Co-authored-by: Marcos Iglesias <miglesiasvalle@lyft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Tests
Documentation
CheckList
Make sure you have checked all steps below to ensure a timely review.