feat: support popular_resources() in mysql_proxy #1488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oard Signed-off-by: xuans <xuan_shen@outlook.com>
Signed-off-by: xuans <xuan_shen@outlook.com>
Signed-off-by: xuans <xuan_shen@outlook.com>
feng-tao
approved these changes
Sep 14, 2021
ozandogrultan
pushed a commit
to deliveryhero/amundsen
that referenced
this pull request
Apr 28, 2022
* support popular_resources endpoint in mysql_proxy for table and dashboard Signed-off-by: xuans <xuan_shen@outlook.com> * refactor code Signed-off-by: xuans <xuan_shen@outlook.com> * fix mypy issue and some refactoring Signed-off-by: xuans <xuan_shen@outlook.com> Signed-off-by: Ozan Dogrultan <ozan.dogrultan@deliveryhero.com>
zacr
pushed a commit
to SaltIO/amundsen
that referenced
this pull request
May 13, 2022
* support popular_resources endpoint in mysql_proxy for table and dashboard Signed-off-by: xuans <xuan_shen@outlook.com> * refactor code Signed-off-by: xuans <xuan_shen@outlook.com> * fix mypy issue and some refactoring Signed-off-by: xuans <xuan_shen@outlook.com>
hansadriaans
pushed a commit
to DataChefHQ/amundsen
that referenced
this pull request
Jun 30, 2022
* support popular_resources endpoint in mysql_proxy for table and dashboard Signed-off-by: xuans <xuan_shen@outlook.com> * refactor code Signed-off-by: xuans <xuan_shen@outlook.com> * fix mypy issue and some refactoring Signed-off-by: xuans <xuan_shen@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Context:
https://github.com/amundsen-io/amundsen/blob/main/metadata/metadata_service/api/popular_resources.py#L38
/popular_tables/ endpoint and get_popular_tables() proxy method have been deprecated since version (3.6.0) and will be removed in version 4. Please use /popular_resources/ endpoint instead.get_popular_resources()with the support ofget_popular_tablesandget_popular_dashboardsTests
tests for get_popular_resources were added/updated
Documentation
CheckList
Make sure you have checked all steps below to ensure a timely review.