feat: Add bigquery column mode when consuming bigquery metadata #1491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrwanBaghdad
changed the title
append this information as part of the column type Signed-off-by: MrwanBaghdad <marwan.nabil@deliveryhero.com>
MrwanBaghdad
force-pushed
the
DCAT-182_consume_column_mode
branch
from
93664ea to
974a6b5
Compare
Signed-off-by: MrwanBaghdad <marwan.nabil@deliveryhero.com>
|
cc @xuan616 to take a look |
|
The predefined length of column_type in rds model should be fine with the concatenation of type and mode. I do not have any concern from rds side. Thanks just one nit: what do you think if we use type instead of mode as prefix. cc @MrwanBaghdad |
|
@MrwanBaghdad ci fails |
Signed-off-by: MrwanBaghdad <marwan.nabil@deliveryhero.com>
|
thanks:grinning: |
amommendes
pushed a commit
to amommendes/amundsen
that referenced
this pull request
Jan 21, 2022
…dsen-io#1491) * DCAT-182 Consume column mode when consumeing metadata from bigquery and append this information as part of the column type Signed-off-by: MrwanBaghdad <marwan.nabil@deliveryhero.com> * fix lint issues Signed-off-by: MrwanBaghdad <marwan.nabil@deliveryhero.com> * Use the column type as prefix, instead of mode Signed-off-by: MrwanBaghdad <marwan.nabil@deliveryhero.com> Signed-off-by: Amom Mendes <amommendes@hotmail.com>
ozandogrultan
pushed a commit
to deliveryhero/amundsen
that referenced
this pull request
Apr 28, 2022
…dsen-io#1491) * DCAT-182 Consume column mode when consumeing metadata from bigquery and append this information as part of the column type Signed-off-by: MrwanBaghdad <marwan.nabil@deliveryhero.com> * fix lint issues Signed-off-by: MrwanBaghdad <marwan.nabil@deliveryhero.com> * Use the column type as prefix, instead of mode Signed-off-by: MrwanBaghdad <marwan.nabil@deliveryhero.com> Signed-off-by: Ozan Dogrultan <ozan.dogrultan@deliveryhero.com>
zacr
pushed a commit
to SaltIO/amundsen
that referenced
this pull request
May 13, 2022
…dsen-io#1491) * DCAT-182 Consume column mode when consumeing metadata from bigquery and append this information as part of the column type Signed-off-by: MrwanBaghdad <marwan.nabil@deliveryhero.com> * fix lint issues Signed-off-by: MrwanBaghdad <marwan.nabil@deliveryhero.com> * Use the column type as prefix, instead of mode Signed-off-by: MrwanBaghdad <marwan.nabil@deliveryhero.com>
hansadriaans
pushed a commit
to DataChefHQ/amundsen
that referenced
this pull request
Jun 30, 2022
…dsen-io#1491) * DCAT-182 Consume column mode when consumeing metadata from bigquery and append this information as part of the column type Signed-off-by: MrwanBaghdad <marwan.nabil@deliveryhero.com> * fix lint issues Signed-off-by: MrwanBaghdad <marwan.nabil@deliveryhero.com> * Use the column type as prefix, instead of mode Signed-off-by: MrwanBaghdad <marwan.nabil@deliveryhero.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR intends to add the column mode when consuming column metadata for bigquery. The column mode indicates if the column is of an array type.
Tests
Added a test case for a repeated nested field
Documentation
CheckList
Make sure you have checked all steps below to ensure a timely review.