-
Notifications
You must be signed in to change notification settings - Fork 968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: s3 preview client #1499
feat: s3 preview client #1499
Conversation
bd0e4e6
to
bfc8014
Compare
a418829
to
6fae380
Compare
6fae380
to
a62e3db
Compare
This commit implements a new preview client that gets preview data from S3. The preview client is good for folks who want to persist their preview data somewhere rather than relaying on an external API call that can both fail and take a while depending on the table the query is being run on. In addition to the base client, I implemented a JSON version of the preview client that my organization is using. This fetches data from S3 in a JSON format and works very nicely with marshmellow serialization to the PreviewData format. Signed-off-by: jroof88 <jack.roof@samsara.com>
a62e3db
to
457d23f
Compare
@feng-tao Friendly ping for a review here. This is getting a bit stale. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @jroof88 , I am fine with the pr. But curious: how do you persist preview data into s3 first? and why not trigger an API call or delta sql to fetch the data?
Databricks job that scans our data lake, run a
I thought about this but we want to get something up quickly and the downsides were too great.
|
@jroof88 got it, thanks for the context! |
@jroof88 is it ok to add your company as user list? |
This commit implements a new preview client that gets preview data from S3. The preview client is good for folks who want to persist their preview data somewhere rather than relaying on an external API call that can both fail and take a while depending on the table the query is being run on. In addition to the base client, I implemented a JSON version of the preview client that my organization is using. This fetches data from S3 in a JSON format and works very nicely with marshmellow serialization to the PreviewData format. Signed-off-by: jroof88 <jack.roof@samsara.com> Signed-off-by: Amom Mendes <amommendes@hotmail.com>
This commit implements a new preview client that gets preview data from S3. The preview client is good for folks who want to persist their preview data somewhere rather than relaying on an external API call that can both fail and take a while depending on the table the query is being run on. In addition to the base client, I implemented a JSON version of the preview client that my organization is using. This fetches data from S3 in a JSON format and works very nicely with marshmellow serialization to the PreviewData format. Signed-off-by: jroof88 <jack.roof@samsara.com> Signed-off-by: Ozan Dogrultan <ozan.dogrultan@deliveryhero.com>
This commit implements a new preview client that gets preview data from S3. The preview client is good for folks who want to persist their preview data somewhere rather than relaying on an external API call that can both fail and take a while depending on the table the query is being run on. In addition to the base client, I implemented a JSON version of the preview client that my organization is using. This fetches data from S3 in a JSON format and works very nicely with marshmellow serialization to the PreviewData format. Signed-off-by: jroof88 <jack.roof@samsara.com>
This commit implements a new preview client that gets preview data from S3. The preview client is good for folks who want to persist their preview data somewhere rather than relaying on an external API call that can both fail and take a while depending on the table the query is being run on. In addition to the base client, I implemented a JSON version of the preview client that my organization is using. This fetches data from S3 in a JSON format and works very nicely with marshmellow serialization to the PreviewData format. Signed-off-by: jroof88 <jack.roof@samsara.com>
Summary of Changes
This commit implements a new preview client that gets preview data from S3. The preview client is good for folks who want to persist their preview data somewhere rather than relaying on an external API call that can both fail and take a while depending on the table the query is being run on.
In addition to the base client, I implemented a JSON version of the preview client that my organization is using. This fetches data from S3 in a JSON format and works very nicely with marshmellow serialization to the PreviewData format.
Tests
N/A. I didn't see tests for any other preview client so I decided not to implement any. The preview clients seem to be fairly custom so testing is probably overkill.
Documentation
Added a documentation file adjacent to the Apache Superset Preview Client docs 👍
CheckList
Make sure you have checked all steps below to ensure a timely review.