Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: stat is_metric field #1500

Merged
merged 7 commits into from
Sep 22, 2021
Merged

feat: stat is_metric field #1500

merged 7 commits into from
Sep 22, 2021

Conversation

allisonsuarez
Copy link
Contributor

@allisonsuarez allisonsuarez commented Sep 22, 2021

Summary of Changes

  • Added is_metric field to Stat model so that we can distinguish between stats about the data in a table and metrics related to the table itself (ex: usage).

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
@allisonsuarez allisonsuarez requested a review from a team as a code owner September 22, 2021 18:37
@boring-cyborg boring-cyborg bot added area:common From common folder category:models labels Sep 22, 2021
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
@allisonsuarez allisonsuarez merged commit 60f99e8 into main Sep 22, 2021
@allisonsuarez allisonsuarez deleted the asm-metrics-stats-common branch September 22, 2021 20:55
amommendes pushed a commit to amommendes/amundsen that referenced this pull request Jan 21, 2022
* chore: bumped version of commonm

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* feat: stat is_metric field

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* bumped version

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* version minor bump

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
Signed-off-by: Amom Mendes <amommendes@hotmail.com>
ozandogrultan pushed a commit to deliveryhero/amundsen that referenced this pull request Apr 28, 2022
* chore: bumped version of commonm

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* feat: stat is_metric field

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* bumped version

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* version minor bump

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
Signed-off-by: Ozan Dogrultan <ozan.dogrultan@deliveryhero.com>
zacr pushed a commit to SaltIO/amundsen that referenced this pull request May 13, 2022
* chore: bumped version of commonm

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* feat: stat is_metric field

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* bumped version

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* version minor bump

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
hansadriaans pushed a commit to DataChefHQ/amundsen that referenced this pull request Jun 30, 2022
* chore: bumped version of commonm

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* feat: stat is_metric field

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* bumped version

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* version minor bump

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:common From common folder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants