Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Apache Superset Chart extractor #1504

Merged
merged 2 commits into from
Sep 27, 2021

Conversation

vazmeee
Copy link
Contributor

@vazmeee vazmeee commented Sep 27, 2021

Summary of Changes

Fixed Apache Superser chart extractor _get_dashboard_details function

@vazmeee vazmeee requested a review from a team as a code owner September 27, 2021 08:00
@boring-cyborg boring-cyborg bot added the area:databuilder From databuilder folder label Sep 27, 2021
@boring-cyborg
Copy link

boring-cyborg bot commented Sep 27, 2021

Congratulations on your first Pull Request and welcome to Amundsen community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/amundsen-io/amundsen/blob/main/CONTRIBUTING.md)

Copy link
Contributor

@mgorsk1 mgorsk1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Signed-off-by: vazmeee <sakirepalli.srivamsi@gmail.com>
Signed-off-by: vazmeee <sakirepalli.srivamsi@gmail.com>
@vazmeee vazmeee force-pushed the superset-extractor-fix branch from 0ba0028 to 08b3b3e Compare September 27, 2021 08:34
@mgorsk1 mgorsk1 merged commit 03d2651 into amundsen-io:main Sep 27, 2021
@boring-cyborg
Copy link

boring-cyborg bot commented Sep 27, 2021

Awesome work, congrats on your first merged pull request!

amommendes pushed a commit to amommendes/amundsen that referenced this pull request Jan 21, 2022
Signed-off-by: vazmeee <sakirepalli.srivamsi@gmail.com>
Signed-off-by: Amom Mendes <amommendes@hotmail.com>
ozandogrultan pushed a commit to deliveryhero/amundsen that referenced this pull request Apr 28, 2022
Signed-off-by: vazmeee <sakirepalli.srivamsi@gmail.com>
Signed-off-by: Ozan Dogrultan <ozan.dogrultan@deliveryhero.com>
zacr pushed a commit to SaltIO/amundsen that referenced this pull request May 13, 2022
Signed-off-by: vazmeee <sakirepalli.srivamsi@gmail.com>
hansadriaans pushed a commit to DataChefHQ/amundsen that referenced this pull request Jun 30, 2022
Signed-off-by: vazmeee <sakirepalli.srivamsi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:databuilder From databuilder folder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants