Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Report an issue - allow user to set ticket priority #1508

Merged
merged 8 commits into from
Oct 5, 2021
Merged

feat: Report an issue - allow user to set ticket priority #1508

merged 8 commits into from
Oct 5, 2021

Conversation

kristenarmes
Copy link
Contributor

Summary of Changes

This change adds a set of radio buttons to the Report an issue modal that will allow users to select a priority from the levels P3-P0 instead of automatically creating tickets only with the default P2.

Tests

A few JS and python tests were modified to include the priority_level field anywhere issue creation is tested.

Documentation

N/A

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does

@kristenarmes
Adding ability to set priority when reporting an issue
b3ebfb5 
Signed-off-by: Kristen Armes <karmes@lyft.com>
@kristenarmes
Use priority level instead of severity name
78b6453 
Signed-off-by: Kristen Armes <karmes@lyft.com>
@kristenarmes
Use P3-P0 for priority buttons
63a6d64 
Signed-off-by: Kristen Armes <karmes@lyft.com>
@kristenarmes
Updating betterer results
6aba9db 
Signed-off-by: Kristen Armes <karmes@lyft.com>
@boring-cyborg boring-cyborg bot added area:frontend From the Frontend folder category:api labels Sep 30, 2021
@kristenarmes
Fix lint
8fe6b24 
Signed-off-by: Kristen Armes <karmes@lyft.com>
@kristenarmes
Copy link
Contributor Author

Note: I did not have a way to verify the integration of this feature with Asana, so I've reached out to someone at the company who had me apply for a sandbox premium account to test my change. Once that account has been provisioned and I have tested the Asana client change, I will set this PR as ready to be reviewed.

@kristenarmes
Fixing setting of priority enum value for Asana task
5f254ba 
Signed-off-by: Kristen Armes <karmes@lyft.com>
@kristenarmes kristenarmes marked this pull request as ready for review October 5, 2021 00:54
Golodhros
Golodhros reviewed Oct 5, 2021
View reviewed changes
Copy link
Member

@Golodhros Golodhros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only some minor comments.

@kristenarmes
Addressing PR comments
68302e4 
Signed-off-by: Kristen Armes <karmes@lyft.com>
Golodhros
Golodhros approved these changes Oct 5, 2021
View reviewed changes
Copy link
Member

@Golodhros Golodhros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kristenarmes
Changing submit label constant
e551a83 
Signed-off-by: Kristen Armes <karmes@lyft.com>
@Golodhros Golodhros merged commit f34c953 into amundsen-io:main Oct 5, 2021
@kristenarmes kristenarmes deleted the report-issue-allow-priority-setting branch October 5, 2021 22:16
amommendes pushed a commit to amommendes/amundsen that referenced this pull request Jan 21, 2022
@kristenarmes @amommendes
feat: Report an issue - allow user to set ticket priority (amundsen-i…
fde967d 
…o#1508)

* Adding ability to set priority when reporting an issue

Signed-off-by: Kristen Armes <karmes@lyft.com>

* Use priority level instead of severity name

Signed-off-by: Kristen Armes <karmes@lyft.com>

* Use P3-P0 for priority buttons

Signed-off-by: Kristen Armes <karmes@lyft.com>

* Updating betterer results

Signed-off-by: Kristen Armes <karmes@lyft.com>

* Fix lint

Signed-off-by: Kristen Armes <karmes@lyft.com>

* Fixing setting of priority enum value for Asana task

Signed-off-by: Kristen Armes <karmes@lyft.com>

* Addressing PR comments

Signed-off-by: Kristen Armes <karmes@lyft.com>

* Changing submit label constant

Signed-off-by: Kristen Armes <karmes@lyft.com>
Signed-off-by: Amom Mendes <amommendes@hotmail.com>
ozandogrultan pushed a commit to deliveryhero/amundsen that referenced this pull request Apr 28, 2022
@kristenarmes @ozandogrultan
feat: Report an issue - allow user to set ticket priority (amundsen-i…
c44bbc6 
…o#1508)

* Adding ability to set priority when reporting an issue

Signed-off-by: Kristen Armes <karmes@lyft.com>

* Use priority level instead of severity name

Signed-off-by: Kristen Armes <karmes@lyft.com>

* Use P3-P0 for priority buttons

Signed-off-by: Kristen Armes <karmes@lyft.com>

* Updating betterer results

Signed-off-by: Kristen Armes <karmes@lyft.com>

* Fix lint

Signed-off-by: Kristen Armes <karmes@lyft.com>

* Fixing setting of priority enum value for Asana task

Signed-off-by: Kristen Armes <karmes@lyft.com>

* Addressing PR comments

Signed-off-by: Kristen Armes <karmes@lyft.com>

* Changing submit label constant

Signed-off-by: Kristen Armes <karmes@lyft.com>
Signed-off-by: Ozan Dogrultan <ozan.dogrultan@deliveryhero.com>
zacr pushed a commit to SaltIO/amundsen that referenced this pull request May 13, 2022
@kristenarmes
feat: Report an issue - allow user to set ticket priority (amundsen-i…
db5d211 
…o#1508)

* Adding ability to set priority when reporting an issue

Signed-off-by: Kristen Armes <karmes@lyft.com>

* Use priority level instead of severity name

Signed-off-by: Kristen Armes <karmes@lyft.com>

* Use P3-P0 for priority buttons

Signed-off-by: Kristen Armes <karmes@lyft.com>

* Updating betterer results

Signed-off-by: Kristen Armes <karmes@lyft.com>

* Fix lint

Signed-off-by: Kristen Armes <karmes@lyft.com>

* Fixing setting of priority enum value for Asana task

Signed-off-by: Kristen Armes <karmes@lyft.com>

* Addressing PR comments

Signed-off-by: Kristen Armes <karmes@lyft.com>

* Changing submit label constant

Signed-off-by: Kristen Armes <karmes@lyft.com>
hansadriaans pushed a commit to DataChefHQ/amundsen that referenced this pull request Jun 30, 2022
@kristenarmes
feat: Report an issue - allow user to set ticket priority (amundsen-i…
e6f21ba 
…o#1508)

* Adding ability to set priority when reporting an issue

Signed-off-by: Kristen Armes <karmes@lyft.com>

* Use priority level instead of severity name

Signed-off-by: Kristen Armes <karmes@lyft.com>

* Use P3-P0 for priority buttons

Signed-off-by: Kristen Armes <karmes@lyft.com>

* Updating betterer results

Signed-off-by: Kristen Armes <karmes@lyft.com>

* Fix lint

Signed-off-by: Kristen Armes <karmes@lyft.com>

* Fixing setting of priority enum value for Asana task

Signed-off-by: Kristen Armes <karmes@lyft.com>

* Addressing PR comments

Signed-off-by: Kristen Armes <karmes@lyft.com>

* Changing submit label constant

Signed-off-by: Kristen Armes <karmes@lyft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Golodhros Golodhros Golodhros approved these changes

@allisonsuarez allisonsuarez Awaiting requested review from allisonsuarez allisonsuarez is a code owner

@dorianj dorianj Awaiting requested review from dorianj

@feng-tao feng-tao Awaiting requested review from feng-tao feng-tao is a code owner

@mgorsk1 mgorsk1 Awaiting requested review from mgorsk1 mgorsk1 is a code owner

@sewardgw sewardgw Awaiting requested review from sewardgw sewardgw is a code owner

@ttannis ttannis Awaiting requested review from ttannis ttannis is a code owner

@verdan verdan Awaiting requested review from verdan verdan is a code owner

@youngyjd youngyjd Awaiting requested review from youngyjd youngyjd is a code owner

Assignees
No one assigned
Labels
area:frontend From the Frontend folder
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kristenarmes @Golodhros