Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add tracking to search resource selector #1532

Merged
merged 5 commits into from
Oct 14, 2021
Merged

feat: Add tracking to search resource selector #1532

merged 5 commits into from
Oct 14, 2021

Conversation

danwom
Copy link

@danwom danwom commented Oct 13, 2021

Summary of Changes

Adds click tracking to the search resource selector

Tests

Documentation

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does

Add tracking to search resource selector
74b6177 
Signed-off-by: Daniel Won <dwon@lyft.com>
@boring-cyborg boring-cyborg bot added area:frontend From the Frontend folder category:ui labels Oct 13, 2021
cleanup lint
e8bbf3c 
Signed-off-by: Daniel Won <dwon@lyft.com>
@allisonsuarez
too me an embarassing amount of time to figuere this out
71d312e 
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
@allisonsuarez
lint fixes
498f2cc 
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
@allisonsuarez
betterer
c2b4790 
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
@allisonsuarez
Copy link
Contributor

💨

@allisonsuarez allisonsuarez merged commit f523c5a into main Oct 14, 2021
@allisonsuarez allisonsuarez deleted the dwon-track-resource-selector branch October 14, 2021 19:19
amommendes pushed a commit to amommendes/amundsen that referenced this pull request Jan 21, 2022
@allisonsuarez @amommendes
feat: Add tracking to search resource selector (amundsen-io#1532)
a6b92a1 
* Add tracking to search resource selector

Signed-off-by: Daniel Won <dwon@lyft.com>

* cleanup lint

Signed-off-by: Daniel Won <dwon@lyft.com>

* too me an embarassing amount of time to figuere this out

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* lint fixes

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* betterer

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

Co-authored-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
Signed-off-by: Amom Mendes <amommendes@hotmail.com>
ozandogrultan pushed a commit to deliveryhero/amundsen that referenced this pull request Apr 28, 2022
@allisonsuarez @ozandogrultan
feat: Add tracking to search resource selector (amundsen-io#1532)
664c542 
* Add tracking to search resource selector

Signed-off-by: Daniel Won <dwon@lyft.com>

* cleanup lint

Signed-off-by: Daniel Won <dwon@lyft.com>

* too me an embarassing amount of time to figuere this out

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* lint fixes

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* betterer

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

Co-authored-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
Signed-off-by: Ozan Dogrultan <ozan.dogrultan@deliveryhero.com>
zacr pushed a commit to SaltIO/amundsen that referenced this pull request May 13, 2022
@allisonsuarez
feat: Add tracking to search resource selector (amundsen-io#1532)
6ded1b6 
* Add tracking to search resource selector

Signed-off-by: Daniel Won <dwon@lyft.com>

* cleanup lint

Signed-off-by: Daniel Won <dwon@lyft.com>

* too me an embarassing amount of time to figuere this out

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* lint fixes

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* betterer

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

Co-authored-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
hansadriaans pushed a commit to DataChefHQ/amundsen that referenced this pull request Jun 30, 2022
@allisonsuarez
feat: Add tracking to search resource selector (amundsen-io#1532)
f2efbfd 
* Add tracking to search resource selector

Signed-off-by: Daniel Won <dwon@lyft.com>

* cleanup lint

Signed-off-by: Daniel Won <dwon@lyft.com>

* too me an embarassing amount of time to figuere this out

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* lint fixes

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* betterer

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

Co-authored-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Golodhros Golodhros Golodhros approved these changes

@allisonsuarez allisonsuarez Awaiting requested review from allisonsuarez allisonsuarez is a code owner

@dorianj dorianj Awaiting requested review from dorianj

@feng-tao feng-tao Awaiting requested review from feng-tao feng-tao is a code owner

@mgorsk1 mgorsk1 Awaiting requested review from mgorsk1 mgorsk1 is a code owner

@sewardgw sewardgw Awaiting requested review from sewardgw sewardgw is a code owner

@ttannis ttannis Awaiting requested review from ttannis ttannis is a code owner

@verdan verdan Awaiting requested review from verdan verdan is a code owner

@youngyjd youngyjd Awaiting requested review from youngyjd youngyjd is a code owner

Assignees
No one assigned
Labels
area:frontend From the Frontend folder
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danwom @allisonsuarez @Golodhros