feat: List available badges on Home & Browse Pages #1535
Conversation
mgorsk1
requested review from
allisonsuarez,
bolkedebruin,
dechoma,
dkunitsk,
dorianj,
feng-tao,
Golodhros,
jinhyukchang,
sewardgw,
ttannis,
verdan,
youngyjd and
a team
as code owners
mgorsk1
force-pushed
the
feat/all_badges_list
branch
from
d5d8acf to
db4460a
Compare
|
It looks like both column badges and table badges are showing in the homepage. I think it maybe better to just display table badges on homepage? clicking on a column badge which takes me to a search result page literally does not show any table |
|
that's a good point @youngyjd, however it is consistent with what happens when you click on column badge (in table view). If we were to change this to table badges only I think the easiest way would be to do it in the metadata proxy - show only badges connected to tables (modify cypher query). unfortunately badge is generic type and there is no other distinction between table/column badges. |
| <h1 className="header-title">{BROWSE_BADGES_TITLE}</h1> | ||
| <hr className="header-hr" /> | ||
| <label className="section-label"> | ||
| <span className="section-title title-2">{AVAILABLE_BADGES_TITLE}</span> |
There was a problem hiding this comment.
The 'title-X' class is deprecated, please add the stiles to 'section-title' with an extend or use classes like text-body-w2
| @import 'typography'; | ||
|
|
||
| .badges-browse-section { | ||
| margin: 32px 0; |
There was a problem hiding this comment.
Let's try to make this values a multiple of the grid or use the spacer variables
|
|
||
| .badges-browse-section-short { | ||
| .available-badges-header-title { | ||
| @extend %text-title-w1; |
| @import 'variables'; | ||
|
|
||
| .flag { | ||
| border-radius: 5px; |
| [class^='badge-overlay-'] { | ||
| font-size: $font-size-base; | ||
| text-align: center; | ||
| padding: 0.2em 0.6em 0.3em; |
There was a problem hiding this comment.
Again, we are not using ems in Amundsen for the moment
| } | ||
| } | ||
| } | ||
| border-radius: 10px; |
Signed-off-by: Mariusz Górski <gorskimariusz13@gmail.com> Signed-off-by: Amom Mendes <amommendes@hotmail.com>
Signed-off-by: Mariusz Górski <gorskimariusz13@gmail.com>
Signed-off-by: Mariusz Górski <gorskimariusz13@gmail.com>
Signed-off-by: Mariusz Górski <gorskimariusz13@gmail.com>
Summary of Changes
Introduces Available badges on landing page and Browse badges in Browse page.
Available badges component on frontend is rendered only if /badges returns non-empty list of badges
So far all badges are shown under Available badges header - we could go with grouping badges into badge categories (header would contain name of category and list of badges would show badges under this category)
This is follow-up to RFC: amundsen-io/rfcs#44
This PR introduces following changes to UI:
Home Page:
Browse Page:
Tests
Documentation
CheckList
Make sure you have checked all steps below to ensure a timely review.