Column Badge Documentation #962
Conversation
|
@feng-tao could you help me with merging non-related changes 😭 |
|
@alldoami could you rebase your local branch with the upstream master? lots of commits have been merged already which just lack in your local fork. |
|
@feng-tao i think I rebased correctly, but I need to sign now. I only want to sign the two commits that aren't signed but it goes back 78 in the instructions from DCO. |
|
this rebase didn't work -- there are still other merge commits present. |
|
@dorianj I do not see the files changed anymore though... |
|
there is a unknown file ( amundsen-kube-helm/templates/helm/charts/elasticsearch-1.32.5.tgz) added to the pr. |
|
@alldoami do you think you could open a new pr ? The long list of past commit concerns me a bit. Also you could sign the just one commit for the new pr. Sorry for the inconvenience. |
|
@feng-tao fixed! |
Signed-off-by: adoami <adoami@chanzuckerberg.com>
Signed-off-by: adoami <adoami@chanzuckerberg.com>
Signed-off-by: adoami <adoami@chanzuckerberg.com>
Signed-off-by: adoami <adoami@chanzuckerberg.com>
Signed-off-by: adoami <adoami@chanzuckerberg.com> Signed-off-by: GitHub <noreply@github.com>
Summary of Changes
Added examples of how to use API for column badge
Documentation
Relevant to: amundsen-io/amundsenmetadatalibrary#273