repairing link to ModeDashboardExtractor in README #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feng-tao
approved these changes
Mar 30, 2020
|
the cla check fails, normally it is due to you haven't configured your local github setting(email etc). Could you help to fix it? |
|
Hi, it seems I had to sign the CLA (strange it didn't ask me to sign before submiting the PR). Now it seems fine. Sorry for the hurdle and thanks for the great work. |
|
@fBedecarrats seems you closed the PR before it got merged. Can you re-open? |
|
thanks @jornh bringing it up, just reopen the pr :) |
|
don't worry, i reopen your pr and merge it. Previously your pr is closed without merge which causes the confusion. |
|
Yep exactly, @feng-tao simply grabbed it and did a few clicks before you could 🙂 Thanks both of you! |
PabTorre
pushed a commit
to PabTorre/amundsendatabuilder
that referenced
this pull request
May 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cf. issue amundsen-io/amundsen#348
Summary of Changes
The last sentence of readme was:
The link was dead. I updated it with what seemed to be the right one: https://github.com/lyft/amundsendatabuilder/blob/master/databuilder/extractor/dashboard/mode_analytics/mode_dashboard_extractor.py