Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Issues with inconsistency in case conversion #388

Merged
merged 4 commits into from
Oct 19, 2020
Merged

fix: Issues with inconsistency in case conversion #388

merged 4 commits into from
Oct 19, 2020

Conversation

joshthoward
Copy link
Contributor

Summary of Changes

Fixes issues with inconsistency in case conversion, specifically issues #758 & #596

Tests

No new test were added, expected output in some tests were updated to reflect the removal of the case conversion. Deprecation warnings for self.assertEquals() were resolved by replacing with self.assertEqual().

Documentation

N/A

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • [-] PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • [-] PR includes a summary of changes.
  • [-] PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • [-] In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
  • [-] PR passes make test

Josh Howard added 4 commits October 10, 2020 09:05
Signed-off-by: Josh Howard <josh.t.howard@ey.com>
Signed-off-by: Josh Howard <josh.t.howard@ey.com>
Signed-off-by: Josh Howard <josh.t.howard@ey.com>
@feng-tao
Copy link
Member

thanks @joshthoward !

@feng-tao feng-tao merged commit 9595866 into amundsen-io:master Oct 19, 2020
@joshthoward
Copy link
Contributor Author

joshthoward commented Oct 19, 2020

NP

There are two things that should be noted for future reference:

  1. I left the tag case conversion in the model code here. It seemed to make sense for displaying tags.
  2. Case conversion going forward should be done by extractors if needed. There is a precedent for this here.

@feng-tao Just as a point of curiosity, how do you see the versioning updating upon release given that this is a potential breaking change to the data model?

@feng-tao
Copy link
Member

we could do 4.0.0 in next release. cc @allisonsuarez @dikshathakur3119

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants