Renaming distinct to unique values all over

amundsen_application/static/js/config/config-types.ts

@@ -144,7 +144,7 @@ type SortCriteriaConfig = {
  * Stats configuration options
  */
 type StatsConfig = {
-  distinctTypeName: string;
+  uniqueValueTypeName: string;
 };
 
 /**

amundsen_application/static/js/config/config-utils.ts

@@ -84,11 +84,12 @@ export function getAnalyticsConfig(): AnalyticsConfig {
 }
 
 /**
- * Returns the stat type name for the distinct stat type
+ * Returns the stat type name for the unique value stat type
  * @returns string or undefined
  */
-export function getDistinctStatTypeName(): string | undefined {
-  return AppConfig.resourceConfig[ResourceType.table].stats?.distinctTypeName;
+export function getUniqueValueStatTypeName(): string | undefined {
+  return AppConfig.resourceConfig[ResourceType.table].stats
+    ?.uniqueValueTypeName;
 }
 
 /*

amundsen_application/static/js/config/index.spec.ts

@@ -86,15 +86,15 @@ describe('getAnalyticsConfig', () => {
   });
 });
 
-describe('getDistinctStatTypeName', () => {
-  it('returns the distinct stat type key name', () => {
+describe('getUniqueValueStatTypeName', () => {
+  it('returns the unique value stat type key name', () => {
     const expectedValue = 'test';
 
     AppConfig.resourceConfig[ResourceType.table].stats = {
-      distinctTypeName: expectedValue,
+      uniqueValueTypeName: expectedValue,
     };
 
-    expect(ConfigUtils.getDistinctStatTypeName()).toBe(expectedValue);
+    expect(ConfigUtils.getUniqueValueStatTypeName()).toBe(expectedValue);
   });
 });
 

amundsen_application/static/js/utils/index.spec.ts

@@ -8,7 +8,7 @@ import * as NumberUtils from './numberUtils';
 import * as StatUtils from './stats';
 
 jest.mock('config/config-utils', () => ({
-  getDistinctStatTypeName: jest.fn(() => 'distinctValues'),
+  getUniqueValueStatTypeName: jest.fn(() => 'distinctValues'),
   getNumberFormat: jest.fn(() => null),
 }));
 

amundsen_application/static/js/utils/stats.ts

@@ -1,6 +1,6 @@
 import { formatDate } from 'utils/dateUtils';
 
-import { getDistinctStatTypeName } from 'config/config-utils';
+import { getUniqueValueStatTypeName } from 'config/config-utils';
 
 import { ColumnUniqueValues, TableColumnStats } from 'interfaces/index';
 
@@ -12,15 +12,15 @@ const parseRawUniqueValues = (uniqueValues: string) =>
   JSON.parse(uniqueValues.split("'").join('"'));
 
 /**
- * Parses the stats' distinct values key into an array of
+ * Parses the stats' unique values key into an array of
  * objects with value and count properties
  * @param statsList
  * @returns ColumnUniqueValues[]
  */
 export const getUniqueValues = (
   statsList: TableColumnStats[]
 ): ColumnUniqueValues[] | [] => {
-  const uniqueValuesKey = getDistinctStatTypeName();
+  const uniqueValuesKey = getUniqueValueStatTypeName();
   if (!uniqueValuesKey) {
     return [];
   }
@@ -39,12 +39,12 @@ export const getUniqueValues = (
 };
 
 /**
- * Removes any stat identified as a distinct value
+ * Removes any stat identified as a unique value
  * @param statsList
  * @returns TableColumnStats[]
  */
 export const filterOutUniqueValues = (statsList: TableColumnStats[]) => {
-  const uniqueValuesKey = getDistinctStatTypeName();
+  const uniqueValuesKey = getUniqueValueStatTypeName();
 
   return statsList.filter((item) => item.stat_type !== uniqueValuesKey);
 };

docs/application_config.md

@@ -140,7 +140,7 @@ To achieve this, you will need to modify your custom configuration (config-custo
 [ResourceType.table]: {
   //...
   stats: {
-    distinctTypeName: "keyNameExample",
+    uniqueValueTypeName: "keyNameExample",
   },
 }
 ```