Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add total_usage in get_attrs fun #136

Merged
merged 1 commit into from
Sep 2, 2020

Conversation

PaschalisDim
Copy link
Contributor

Summary of Changes

Include a summary of changes then remove this line

Tests

What tests did you add or modify and why? If no tests were added or modified, explain why. Remove this line

Documentation

What documentation did you add or modify and why? Add any relevant links then remove this line

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
  • PR passes make test

@PaschalisDim PaschalisDim changed the title Add total_usage in get_attrs fun fix: Add total_usage in get_attrs fun Aug 26, 2020
Signed-off-by: Paschalis Dimitriou <paschalis.dimitriou@gmail.com>
@PaschalisDim PaschalisDim force-pushed the BugFixTotalUsageInSearch branch from b19f021 to 454a7d3 Compare August 26, 2020 10:56
@PaschalisDim
Copy link
Contributor Author

Removed the comma from the last item of the list, while adding the total_usage, so that it is not equal to 0 in the search API.

@PaschalisDim
Copy link
Contributor Author

cc @feng-tao

@feng-tao feng-tao merged commit 03b7dc9 into amundsen-io:master Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants