-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mapper, a helper tool for making 2D maps from SPH particles. #733
Conversation
Makes life easier compared to directly using FiMap.
@ipelupessy any thoughts? |
could be good idea... you may need to add an example for the usage (and maybe some doc string.) though..hard to see how to use it.. |
|
yeah, use case will come in my plotting tool (see https://gist.github.com/rieder/abe1773776a9bb08503e06723d48ca66 for now). I found it better to separate these than have them in one big file. |
I'm still working on it, syntax will probably change as I add |
I simplified it and added a use case example. Still more to be done. |
I've added (a simplified version of) plot_hydro, which uses mapper. |
@ipelupessy I can't see anything wrong. This is part of the right PR and all. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 28 days if no further activity occurs. Thank you for your contributions. |
ready for merge? |
Almost. I’ve been using it but I need to add a nice example.
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 28 days if no further activity occurs. Thank you for your contributions. |
suggest merge |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 28 days if no further activity occurs. Thank you for your contributions. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 28 days if no further activity occurs. Thank you for your contributions. |
It's good enough, merging! |
Makes life easier compared to directly using FiMap.
Plan is to expand this mapper to also use it with Fresco and to add a plotting tool separately.