Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mapper, a helper tool for making 2D maps from SPH particles. #733

Merged
merged 27 commits into from
Mar 14, 2023

Conversation

rieder
Copy link
Member

@rieder rieder commented Feb 19, 2021

Makes life easier compared to directly using FiMap.
Plan is to expand this mapper to also use it with Fresco and to add a plotting tool separately.

Makes life easier compared to directly using FiMap.
@rieder
Copy link
Member Author

rieder commented Feb 19, 2021

@ipelupessy any thoughts?

@ipelupessy
Copy link
Member

could be good idea... you may need to add an example for the usage (and maybe some doc string.) though..hard to see how to use it..

@ipelupessy
Copy link
Member

ipelupessy commented Feb 19, 2021

btw, I think we are using ascii encoding for the source? never mind its default utf-8 in python3

@rieder
Copy link
Member Author

rieder commented Feb 19, 2021

could be good idea... you may need to add an example for the usage (and maybe some doc string.) though..hard to see how to use it..

yeah, use case will come in my plotting tool (see https://gist.github.com/rieder/abe1773776a9bb08503e06723d48ca66 for now). I found it better to separate these than have them in one big file.

@rieder
Copy link
Member Author

rieder commented Feb 19, 2021

I'm still working on it, syntax will probably change as I add @property decorators and such.

@rieder
Copy link
Member Author

rieder commented Feb 19, 2021

I simplified it and added a use case example. Still more to be done.

@rieder
Copy link
Member Author

rieder commented Jul 7, 2021

I've added (a simplified version of) plot_hydro, which uses mapper.
This seems to work well, but I'm not sure if it is "ready to merge" yet.

@rieder
Copy link
Member Author

rieder commented Feb 8, 2022

hmm, would check your branches and remotes...

@ipelupessy I can't see anything wrong. This is part of the right PR and all.

@stale
Copy link

stale bot commented Apr 9, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 28 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Issues that have been around for a while without updates label Apr 9, 2022
@ipelupessy
Copy link
Member

ready for merge?

@stale stale bot removed the stale Issues that have been around for a while without updates label Apr 9, 2022
@rieder
Copy link
Member Author

rieder commented Apr 9, 2022 via email

@stale
Copy link

stale bot commented Jun 8, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 28 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Issues that have been around for a while without updates label Jun 8, 2022
@ipelupessy
Copy link
Member

suggest merge

@stale stale bot removed the stale Issues that have been around for a while without updates label Jun 9, 2022
@stale
Copy link

stale bot commented Sep 10, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 28 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Issues that have been around for a while without updates label Sep 10, 2022
@rieder rieder removed the stale Issues that have been around for a while without updates label Sep 10, 2022
@stale
Copy link

stale bot commented Nov 9, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 28 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Issues that have been around for a while without updates label Nov 9, 2022
@rieder rieder added feature request and removed stale Issues that have been around for a while without updates labels Nov 9, 2022
@rieder rieder requested a review from a team as a code owner March 14, 2023 13:49
@rieder
Copy link
Member Author

rieder commented Mar 14, 2023

It's good enough, merging!

@rieder rieder merged commit 9afb520 into amusecode:main Mar 14, 2023
@rieder rieder deleted the add_mapper branch March 14, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants