-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remote workers for socket channel #944
Remote workers for socket channel #944
Conversation
…r local running tbd: dynamic python worker codes, debug support
src/amuse/rfi/channel.py
Outdated
@@ -35,8 +35,9 @@ | |||
from amuse.support.options import OptionalAttributes, option, GlobalOptions | |||
from amuse.support.core import late | |||
from amuse.support import exceptions | |||
from amuse.support import get_amuse_root_dir | |||
from amuse.support import get_amuse_root_dir, get_amuse_directory_root |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these function names are easy to confuse...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yea..in amusifier its called --get-amuse-package-dir, maybe thats better?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
get-amuse-package-root?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
prob consistency is best..
@ipelupessy could you include an example of how to use this? Otherwise it looks good to me. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 28 days if no further activity occurs. Thank you for your contributions. |
This PR allows workers to be started remotely using sockets_channel under the following conditions: