-
Notifications
You must be signed in to change notification settings - Fork 127
FluentAvalonia preview 5 #284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feature: Enable trimming and NativeAOT support
…lonia into v2_preview5_final
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I stupidly merged the ThemeDictionary PR into master instead of the preview 5 branch (which took the preview5 branch with it), but its fine. This PR will be the last few changes I want to get into preview 5 before releasing it. I'm aiming to have it ready no later than Monday.
I'm mostly focusing on some styling fixes now.
NOTE
The default values of `PreferSystemTheme` and `PreferUserAccentColor` are now false. Technically, they were broken a while ago because FATheme is loaded in the constructor before those properties are set and if you set it to false, it wasn't respected. This really came into play with the new theme stuff because if it loads with true but should be false, the system theme was written out to App.RequestedThemeVariant, which would overwrite your preferred setting and couldn't be reversed. This more affected PreferSystemTheme than accent color, but to be safe I've also switched that to false by default