Skip to content

FluentAvalonia preview 5 #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Feb 6, 2023
Merged

FluentAvalonia preview 5 #284

merged 19 commits into from
Feb 6, 2023

Conversation

amwx
Copy link
Owner

@amwx amwx commented Feb 4, 2023

I stupidly merged the ThemeDictionary PR into master instead of the preview 5 branch (which took the preview5 branch with it), but its fine. This PR will be the last few changes I want to get into preview 5 before releasing it. I'm aiming to have it ready no later than Monday.

I'm mostly focusing on some styling fixes now.

  • Fixed NumericUpDown control theme to behave more like NumberBox
  • A couple SettingsExpander related fixes
  • Added the styles for RefreshContainer/RefreshVisualizer
  • Added a TextCommandBarFlyout as the ContextFlyout for SelectableTextBlock

NOTE

The default values of `PreferSystemTheme` and `PreferUserAccentColor` are now false. Technically, they were broken a while ago because FATheme is loaded in the constructor before those properties are set and if you set it to false, it wasn't respected. This really came into play with the new theme stuff because if it loads with true but should be false, the system theme was written out to App.RequestedThemeVariant, which would overwrite your preferred setting and couldn't be reversed. This more affected PreferSystemTheme than accent color, but to be safe I've also switched that to false by default

@adirh3
Copy link
Contributor

adirh3 commented Feb 5, 2023

In case you are not aware of this, seems like all high contrast resources fail to add using TryAddResource causing these exceptions to be thrown on startup -
image
Method TryLoadHighContrastThemeColors

@amwx
Copy link
Owner Author

amwx commented Feb 6, 2023

In case you are not aware of this, seems like all high contrast resources fail to add using TryAddResource causing these exceptions to be thrown on startup - image Method TryLoadHighContrastThemeColors

The out of range exception should now be fixed. However, note that the high contrast theme is broken in preview5 b/c of an issue with DynamicResource so most of it probably won't load anyway. That fix wasn't prioritized into preview5 upstream so it has to wait until preview6.

@amwx amwx merged commit 1ce716e into master Feb 6, 2023
@amwx amwx mentioned this pull request Feb 6, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants