Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong placeholder #694

Closed
kerlama opened this issue May 11, 2020 · 2 comments
Closed

Wrong placeholder #694

kerlama opened this issue May 11, 2020 · 2 comments

Comments

@kerlama
Copy link

kerlama commented May 11, 2020

What I expected

Placeholder for password field should say: Password instead of optional

What happened instead

"optional" placeholder shown instead

Steps to reproduce the issue

For some reason, when amazon payment is enabled but not configured it replaces email.html form element on the magento checkout and you ll see placeholder says optional for password instead "Password". This was fixed in magento here:

magento/magento2#16378

Your setup

  • Magento version: 2.3.5
  • Amazon Pay Extension Version: 3.4.1
  • Magento Edition: Community
@tarishah
Copy link
Contributor

Thanks @kerlama for reporting. We will get this looked at and resolved.

@zichicc
Copy link
Contributor

zichicc commented Jun 11, 2020

Hi @kerlama ,
I'm happy to tell you that a fix for this issue has just been merged into the plugin ( 1dc1c2e ) and will be shipped in the next Magento releases. Thanks for your contribution.

Thanks
Regards

Christian

@zichicc zichicc closed this as completed Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants