Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong placeholder for password field in the checkout page #16378

Closed
mohitka opened this issue Jun 25, 2018 · 12 comments
Closed

Wrong placeholder for password field in the checkout page #16378

mohitka opened this issue Jun 25, 2018 · 12 comments
Assignees
Labels
Fixed in 2.1.x The issue has been fixed in 2.1 release line Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed

Comments

@mohitka
Copy link

mohitka commented Jun 25, 2018

Summary of the issue: Wrong placeholder for password field in the checkout page

Preconditions

  1. Magento version: 2.2.3 and 2.2.4
  2. Edition: Community Edition (Open Source Edition)

Steps to reproduce

  1. Add a product to cart and go to checkout page.
  2. Enter any registered email so that the password field appears.
  3. The password field shows the placeholder Optional, but when we click on Login button without filling password, it shows the validation error.

Expected result

  1. Since the password is a required field, the placeholder for the password field should not be Optional.

Actual result

  1. The password field in the checkout page is currently seeming conflicting in nature. It is showing Optional in a placeholder, but after validation, it is showing validation error This is a required field.

validation-password

@magento-engcom-team
Copy link
Contributor

Hi @mohitka. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me {$VERSION} instance

where {$VERSION} is version tags (starting from 2.2.0+) or develop branches (2.2-develop +).
For more details, please, review the Magento Contributor Assistant documentation.

@mohitka do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Jun 25, 2018
@hitesh-wagento
Copy link
Contributor

Hi @mohitka

Do you need to change placeholder text Optional to Password ?

@mohitka
Copy link
Author

mohitka commented Jun 25, 2018

No @hitesh-wagento I was just working on a project and found this issue. I thought it should be reported for the sake of the good experience of Magento.

I hope the issue would be checked and fixed in the future releases of Magento.

@hitesh-wagento
Copy link
Contributor

Hi @mohitka

Yes, I will fix this issue and fixed in next release.

The issue is placeholder text Optional is wrong, Right ?

@mohitka
Copy link
Author

mohitka commented Jun 25, 2018

Yes @hitesh-wagento

@hitesh-wagento
Copy link
Contributor

I am working on this

@hitesh-wagento hitesh-wagento self-assigned this Jun 25, 2018
@mohitka
Copy link
Author

mohitka commented Jun 25, 2018

Okay, thanks. So, should I expect the changes in the next release of Magento?

@hitesh-wagento
Copy link
Contributor

Yes, sure

@magento-engcom-team
Copy link
Contributor

Hi @mohitka. Thank you for your report.
The issue has been fixed in #16379 by @hitesh-wagento in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.6 release.

@magento-engcom-team
Copy link
Contributor

Hi @mohitka. Thank you for your report.
The issue has been fixed in #16521 by @hitesh-wagento in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.0 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Jul 5, 2018
@mohitka
Copy link
Author

mohitka commented Jul 6, 2018

Thanks, @hitesh-wagento for fixing and @magento-engcom-team for the update.

@VladimirZaets
Copy link
Contributor

Hi @mohitka. Thank you for your report.
The issue has been fixed in #16526 by @hitesh-wagento in 2.1-develop branch
Related commit(s):

The fix will be available with the upcoming 2.1.15 release.

@VladimirZaets VladimirZaets added the Fixed in 2.1.x The issue has been fixed in 2.1 release line label Jul 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed in 2.1.x The issue has been fixed in 2.1 release line Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed
Projects
None yet
Development

No branches or pull requests

4 participants