Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contributed multibindings in the same round are not picked up by a merged component #22

Closed
ZacSweers opened this issue Sep 11, 2024 · 8 comments

Comments

@ZacSweers
Copy link
Contributor

Repro: slackhq/circuit#1635

./gradlew :samples:kotlin-inject:kspKotlin

The multibinding hints are correctly generated, but they are seemingly not picked up and included into AppComponentMerged for some reason, which is what has me thinking this is a round ordering/deferral issue.

image

@ZacSweers
Copy link
Contributor Author

Talked offline, I was missing that custom annotations also need to have code gen run over them 👍

@ZacSweers ZacSweers closed this as not planned Won't fix, can't repro, duplicate, stale Sep 11, 2024
@marenovakovic
Copy link

I'm facing same issue.
What is the solution.
I don't understand what "custom annotations also need to have code gen run over them" really means.
Are custom annotations in question Circuit code gen annotations?

@vRallev
Copy link
Contributor

vRallev commented Oct 8, 2024

@marenovakovic
Copy link

marenovakovic commented Oct 10, 2024

This is so unstable.
Every time I open a project I get different error.
I was facing same issue as described by Zac and now it's:

Storage for .... is already registered

so I can't test it with @ContributesTo(AppScope::class).
When I fix other issues I'll comment back if steps worked or not.

For now adding @ContributesTo(AppScope::class) results in [ksp] kotlin.io.FileAlreadyExistsException but I'm not sure of it since issues are randomly showing up.
I saw evant/kotlin-inject#414 so I assume it's not released yet.

@ZacSweers
Copy link
Contributor Author

Without a repro case no one can really help you

@marenovakovic
Copy link

@marenovakovic
Copy link

now reproduction repo works fine...

@rk779
Copy link

rk779 commented Oct 28, 2024

For now adding @ContributesTo(AppScope:

Hi @marenovakovic, was this issue fixed [ksp] kotlin.io.FileAlreadyExistsException for you? I'm also randomly getting this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants