Fix FileAlreadyExistsException
#414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vRallev
force-pushed
the
ralf/file-already-exists
branch
from
0d2250d to
78b4a36
Compare
evant
reviewed
Jul 10, 2024
| // Classes keep being processed multiple times and throw a FileAlreadyExistsException in multi round | ||
| // scenarios. The function above getSymbolsWithAnnotation returns deferred symbols twice for some | ||
| // reason in the next round. | ||
| it.qualifiedName |
There was a problem hiding this comment.
Simple enough, I assume a ksp issue is filed for it? Would be nice to include in the comment here
There was a problem hiding this comment.
Done google/ksp#1993
Classes keep being processed multiple times and throw a `FileAlreadyExistsException` in multi round scenarios. The function `getSymbolsWithAnnotation()` returns deferred symbols twice for some reason in the next round. The fix is only applied for classes and not functions yet, because there the issue didn't occur. More care should also be taken for functions, because the qualified name alone is not an indicator to distinguish functions as functions be overloaded and have different parameters.
vRallev
force-pushed
the
ralf/file-already-exists
branch
from
78b4a36 to
7936e26
Compare
evant
approved these changes
Jul 10, 2024
3 tasks
github-merge-queue bot
pushed a commit
to slackhq/circuit
that referenced
this pull request
Sep 16, 2024
This introduces support for kotlin-inject + kotlin-inject-anvil. Note that kotlin-inject needs another release with evant/kotlin-inject#414 to work, so I'm game putting this in the release now but mentioning this caveat. Will remove the snapshots use and just disable the new sample project for now. kotlin-inject-anvil has support for options coming too, but in the meantime I think it's actually fine to check in an anvil hint property too as it doesn't require any runtime anvil APIs and can just be compileOnly. **TODO in the future** - [x] Need a new kotlin-inject release for evant/kotlin-inject#414 - [x] Need anvil support for annotation options: amzn/kotlin-inject-anvil#24 - [ ] Migrate STAR sample (can be a later PR if need be)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Classes keep being processed multiple times and throw a
FileAlreadyExistsExceptionin multi round scenarios. The functiongetSymbolsWithAnnotation()returns deferred symbols twice for some reason in the next round.The fix is only applied for classes and not functions yet, because there the issue didn't occur. More care should also be taken for functions, because the qualified name alone is not an indicator to distinguish functions as functions be overloaded and have different parameters.